Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename function to not have unneeded prefix #5292

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Feb 6, 2025

This is to match the other function names in #5212 and remove the unneeded get_ prefix that isn't used in Rust.

@jtran jtran requested a review from franknoirot February 6, 2025 18:02
Copy link

qa-wolf bot commented Feb 6, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 6, 2025 6:11pm

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (6c635bd) to head (8f31bb1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5292   +/-   ##
=======================================
  Coverage   86.05%   86.05%           
=======================================
  Files          92       92           
  Lines       33204    33204           
=======================================
  Hits        28575    28575           
  Misses       4629     4629           
Flag Coverage Δ
wasm-lib 86.05% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtran jtran merged commit 357bbff into main Feb 7, 2025
32 of 33 checks passed
@jtran jtran deleted the jtran/rename-settings-function branch February 7, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants