-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lower-right corner units menu to read and edit inline settings annotations if present #5212
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5212 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 92 92
Lines 33204 33204
=======================================
Hits 28575 28575
Misses 4629 4629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Actually @franknoirot changing to mm worked in the code but the step export still gave me inches |
So with the project or user-level settings set to |
@franknoirot ok I can reproduce:
|
- Fix thrown error to use the cause field - Fix function names to not use "get"
84a18ae
to
45a9d89
Compare
I don't know why yarn tsc fails on this branch |
Towards #3960. Allows UI to respond to per-file length unit annotations if the currently-opened file has them hand written within:
This allows us to have the UI not lie to users who are savvy enough to already be using per-file units (or who use our recently rewritten samples), ahead of our attempt to provide migrations to per-file units and truly deprecating the project-level setting.