Fix Shift-Click to Deselect Edges/Faces

[max-mrgrsk]

Summary

• Implements proper toggling in the 'Set selection' action so shift-clicking a selected edge/face now removes it from selection instead of duplicating.
• Adds a Playwright test verifying shift-clicking both single and multiple items toggles them on/off correctly.

Changes

Selections:

In ModelingMachineProvider.tsx under 'Set selection', if shift is pressed, we now check if the item is already selected:

• If true, remove it (.filter).
• If false, add it (spread + newItem).

Playwright Test:

Validates selecting/deselecting edges/faces:

• Single edge → shift-click again → deselect.
• Multiple edges + face → shift-click each again → deselect all.

Everything now correctly toggles on shift-click as expected.

Closes: #4760

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Feb 10, 2025 11:16pm

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.90%. Comparing base (e2be66b) to head (eceb0df).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5289      +/-   ##
==========================================
- Coverage   86.05%   85.90%   -0.15%     
==========================================
  Files          92       92              
  Lines       33300    33495     +195     
==========================================
+ Hits        28656    28774     +118     
- Misses       4644     4721      +77     

Flag	Coverage Δ
wasm-lib	85.90% <ø> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pierremtb]

Looks good, and confirmed it's working locally. Thank you!

[franknoirot]

Great work @max-mrgrsk!