Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for edge deselection #4760

Closed
Tracked by #2606
max-mrgrsk opened this issue Dec 11, 2024 · 0 comments · Fixed by #5289
Closed
Tracked by #2606

add support for edge deselection #4760

max-mrgrsk opened this issue Dec 11, 2024 · 0 comments · Fixed by #5289
Assignees
@max-mrgrsk
Labels
dev Issues related to development of the app.
Milestone
v1 Modeling App L...

Comments

@max-mrgrsk
Copy link
Collaborator

max-mrgrsk commented Dec 11, 2024 •
edited
Loading

Issue:

Shift-click is not deselecting already-selected edges/faces.
Instead, it adds them again, resulting in duplicate selections.

Explanation:

Currently, if shift is pressed, the selection logic always adds new selection, causing multiple copies of the same item.

Image

Expected Behavior:

Shift-clicking an already-selected edge/face should remove it from the selection (toggle off).

References:
@max-mrgrsk max-mrgrsk mentioned this issue Dec 11, 2024
Open
53 tasks
@max-mrgrsk max-mrgrsk self-assigned this Dec 11, 2024
@max-mrgrsk max-mrgrsk added the dev Issues related to development of the app. label Dec 11, 2024
@max-mrgrsk max-mrgrsk added this to the v1 Modeling App Launch milestone Dec 11, 2024
@max-mrgrsk max-mrgrsk linked a pull request Feb 6, 2025 that will close this issue
Fix Shift-Click to Deselect Edges/Faces #5289
Merged
@max-mrgrsk max-mrgrsk mentioned this issue Feb 6, 2025
Merged
@pierremtb pierremtb mentioned this issue Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-mrgrsk max-mrgrsk

Labels
dev Issues related to development of the app.
Projects
None yet
Milestone
v1 Modeling App Launch
Development

Successfully merging a pull request may close this issue.

Fix Shift-Click to Deselect Edges/Faces KittyCAD/modeling-app
1 participant
@max-mrgrsk