Conversation
|
I don't really like dumping the whole vdf parser into the code like this. Are you sure there isn't a library to do it? Otherwise I would even prefer if one of use published it as a crate and have Gale use that. |
|
I've looked around but they all seem to be missing the binary parsing or they're outdated but this was the only rust implementation that actually worked. I've made a issue about the crate thing already Tormak9970/Steam-Art-Manager#261 |
- Replace eager ok_or_eyre(format!) with lazy ok_or_else(|| eyre!) in platform.rs - Remove redundant Map.get() check in Toolbar.svelte
4b65263 to
224c1cf
Compare
|
Managed to get the vdf parser published as a crate, so I updated the code and replaced the VDF parser with new-vdf-parser crate 😄 |
|
@Kesomannen is there any blockers on this? |
If you hadn't explicity selected steam, gamePrefs.platform would set to null which hides the option
Makes it look a bit more inline with the rest of the ui
Looks like we need to filter by beta branches, steam lumps everything together. I need to see where steam stores launch options user configs.
I was just trying to respect the existing config behavior but yeah it should probably be default. |
|
For now I just filtered out the beta branch options, since I can't seem to figure out where steam stores beta game preferences. Also I almost completely forgot but also need to filter out options specific for linux, windows and proton. I think I got something but I need to actually test it on a linux machine. |
|
Were you gonna test it more or would you say this is ready to merge? |
|
I haven't had a chance to test the local changes on linux but I can push it. Also probably need to merge in upstream and move the strings to localization stuff. |

Adds support for Steam launch options, allowing users to select different game modes defined by developers (VR, dedicated server, safe mode, etc.) when launching through Steam.
Implementation Notes
appinfo.vdffile