Remove faulty override of reset method in JoypadSpace wrapper#93
Closed
acjh wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks for the focused fix here. PR #106 includes the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://stackoverflow.com/questions/76509663/typeerror-joypadspace-reset-got-an-unexpected-keyword-argument-seed.
JoypadSpacedoesn't correctly override thereset()method ofWrapper.JoypadSpacereset()was implemented forgym0.10.5 in nes-py 0.8.7 (Jul 2018).Wrapperreset()was defined with**kwargsingym0.10.6 (Oct 2018).Though at the time
Envreset()did not accept any parameters.Envreset()started to acceptseedparameter ingym0.22.0 (Feb 2022).Since nes-py now requires
gym>=0.17.2, it is unnecessary to implement (override)reset()method.Type of change
Please select all relevant options:
Since nes-py now requires
gym>=0.17.2, removing the method override is a non-breaking change.How Has This Been Tested?
Not tested yet (I'm not a nes-py user), but the fix is straightforward.
Test Configuration
NIL.
Checklist