Gymnasium support#94
Open
ItaiBear wants to merge 13 commits into
Open
Conversation
gymnasium 0.27 Discrete space returns np.int64 instead of int
ItaiBear
added a commit
to ItaiBear/gym-tetris
that referenced
this pull request
Jul 17, 2023
relies on Kautenja/nes-py#94 also commented out a group of unit tests on the registration as they are irrelevant since ~2019, when access to attributes starting with an underscore was prohibited.
9 tasks
Also added None as a default option for render_mode. Also separated between terminated and truncated instead of a single done internally.
goproslowyo
reviewed
Nov 11, 2023
| 'render.modes': ['rgb_array', 'human'], | ||
| 'render_modes': ['rgb_array', 'human'], | ||
| 'render_fps': 60, | ||
| 'video.frames_per_second': 60 |
There was a problem hiding this comment.
I believe video.frames_per_second can be dropped in favor of render_fps (as seen here).
Suggested change
| 'video.frames_per_second': 60 |
Just make sure to update the sole reference I saw to it here to be target_frame_duration = 1 / env.metadata['render_fps'].
Thanks for keeping your fork up-to-date. I've been basically maintaining my own fork on the side as well so I can play around with RL and NES games.
goproslowyo
approved these changes
Nov 11, 2023
goproslowyo
left a comment
goproslowyo
left a comment
There was a problem hiding this comment.
I've been using the changes in this fork for a few weeks successfully. It'd be nice to get a review and merge on this!
|
This looks good. I have tested it with the latest 1.1.1 gymnasium version, and it works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Readjusted all code including unit tests to support Gymnasium and its API changes.
Drops support for older gym.
Based on #87 and its code review.
As well as #93.
Type of change
Please select all relevant options:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration
Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: arm64-apple-darwin22.1.0
Thread model: posix
Checklist