-
Notifications
You must be signed in to change notification settings - Fork 83
cxx-qt-gen: remove hidden module #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e878d8f
to
cf48196
Compare
Be-ing
reviewed
Jul 24, 2023
6dcc30d
to
e49b9db
Compare
Be-ing
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #617 #587 #620
And needs
UniquePtr
->cxx::UniquePtr
(should be able to make a mechanism in the newutils/
to qualify a given syn type, then use that for other types likePin
too (slightly related to cxx-qt-gen: don't import Pin in hidden module resolving IDE integration #587) Have a generic mechanism in utils to do Pin, UniquePtr, SharedPtr etc which then removes the double definitions in cxx-qt-gen: don't import Pin in hidden module resolving IDE integration #587impl MyObject
needs to beimpl module::MyObject
or have a type/use to bring it inuse cxx_qt::CxxQtType
to be able to userust_mut()
in their methods, but we also don't want to import and "leak" that into the outside scope, so should just be in the method scope if requireduses
fromParsedCxxQtData