Skip to content

Commit f5fa90c

Browse files
ahayzen-kdabBe-ing
authored andcommitted
cxx-qt-gen: remove unused members from generated qobject
1 parent 5c555c2 commit f5fa90c

File tree

9 files changed

+128
-221
lines changed

9 files changed

+128
-221
lines changed

crates/cxx-qt-gen/src/generator/rust/constructor.rs

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use std::collections::BTreeMap;
88
use crate::{
99
generator::{
1010
naming::{namespace::NamespaceName, qobject::QObjectName, CombinedIdent},
11-
rust::qobject::GeneratedRustQObjectBlocks,
11+
rust::qobject::GeneratedRustQObject,
1212
utils::rust::{
1313
syn_ident_cxx_bridge_to_qualified_impl, syn_type_cxx_bridge_to_qualified,
1414
syn_type_is_cxx_bridge_unsafe,
@@ -65,7 +65,7 @@ fn argument_members(args: &[Type]) -> Vec<TokenStream> {
6565
fn generate_default_constructor(
6666
qobject_idents: &QObjectName,
6767
namespace: &NamespaceName,
68-
) -> GeneratedRustQObjectBlocks {
68+
) -> GeneratedRustQObject {
6969
let rust_struct_ident = &qobject_idents.rust_struct.rust;
7070

7171
let create_rs_ident = format_ident!(
@@ -74,7 +74,7 @@ fn generate_default_constructor(
7474
);
7575
let namespace_internals = &namespace.internal;
7676

77-
GeneratedRustQObjectBlocks {
77+
GeneratedRustQObject {
7878
cxx_mod_contents: vec![parse_quote! {
7979
extern "Rust" {
8080
#[cxx_name = "createRs"]
@@ -146,12 +146,12 @@ pub fn generate(
146146
namespace: &NamespaceName,
147147
qualified_mappings: &BTreeMap<Ident, Path>,
148148
module_ident: &Ident,
149-
) -> Result<GeneratedRustQObjectBlocks> {
149+
) -> Result<GeneratedRustQObject> {
150150
if constructors.is_empty() {
151151
return Ok(generate_default_constructor(qobject_idents, namespace));
152152
}
153153

154-
let mut result = GeneratedRustQObjectBlocks::default();
154+
let mut result = GeneratedRustQObject::default();
155155
let namespace_internals = &namespace.internal;
156156

157157
let qobject_name = &qobject_idents.cpp_class.cpp;
@@ -368,7 +368,7 @@ mod tests {
368368
NamespaceName::from_pair_str("ffi", &format_ident!("MyObject"))
369369
}
370370

371-
fn generate_mocked(constructors: &[Constructor]) -> GeneratedRustQObjectBlocks {
371+
fn generate_mocked(constructors: &[Constructor]) -> GeneratedRustQObject {
372372
generate(
373373
constructors,
374374
&mock_name(),
@@ -430,7 +430,7 @@ mod tests {
430430
// This is called by the `multiple_constructors` test so we don't have to
431431
// assert this in two separate tests.
432432
fn assert_empty_constructor_blocks(
433-
blocks: &GeneratedRustQObjectBlocks,
433+
blocks: &GeneratedRustQObject,
434434
namespace_attr: &TokenStream,
435435
) {
436436
assert_tokens_eq(
@@ -528,10 +528,7 @@ mod tests {
528528
);
529529
}
530530

531-
fn assert_full_constructor_blocks(
532-
blocks: &GeneratedRustQObjectBlocks,
533-
namespace_attr: &TokenStream,
534-
) {
531+
fn assert_full_constructor_blocks(blocks: &GeneratedRustQObject, namespace_attr: &TokenStream) {
535532
// the index here starts with 5, as this is part of the larger multiple_constructors test.
536533
assert_tokens_eq(
537534
&blocks.cxx_mod_contents[5],

crates/cxx-qt-gen/src/generator/rust/cxxqttype.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use std::collections::BTreeMap;
77

88
use crate::generator::{
9-
naming::qobject::QObjectName, rust::qobject::GeneratedRustQObjectBlocks,
9+
naming::qobject::QObjectName, rust::qobject::GeneratedRustQObject,
1010
utils::rust::syn_ident_cxx_bridge_to_qualified_impl,
1111
};
1212
use quote::quote;
@@ -17,8 +17,8 @@ use super::fragment::RustFragmentPair;
1717
pub fn generate(
1818
qobject_ident: &QObjectName,
1919
qualified_mappings: &BTreeMap<Ident, Path>,
20-
) -> Result<GeneratedRustQObjectBlocks> {
21-
let mut blocks = GeneratedRustQObjectBlocks::default();
20+
) -> Result<GeneratedRustQObject> {
21+
let mut blocks = GeneratedRustQObject::default();
2222

2323
let cpp_struct_ident = &qobject_ident.cpp_class.rust;
2424
let rust_struct_ident = &qobject_ident.rust_struct.rust;

crates/cxx-qt-gen/src/generator/rust/inherit.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// SPDX-License-Identifier: MIT OR Apache-2.0
55

66
use crate::{
7-
generator::{naming::qobject::QObjectName, rust::qobject::GeneratedRustQObjectBlocks},
7+
generator::{naming::qobject::QObjectName, rust::qobject::GeneratedRustQObject},
88
parser::inherit::ParsedInheritedMethod,
99
};
1010
use proc_macro2::TokenStream;
@@ -14,8 +14,8 @@ use syn::{Item, Result};
1414
pub fn generate(
1515
qobject_ident: &QObjectName,
1616
methods: &[ParsedInheritedMethod],
17-
) -> Result<GeneratedRustQObjectBlocks> {
18-
let mut blocks = GeneratedRustQObjectBlocks::default();
17+
) -> Result<GeneratedRustQObject> {
18+
let mut blocks = GeneratedRustQObject::default();
1919
let qobject_name = &qobject_ident.cpp_class.rust;
2020

2121
let mut bridges = methods
@@ -71,7 +71,7 @@ mod tests {
7171
fn generate_from_foreign(
7272
method: ForeignItemFn,
7373
safety: Safety,
74-
) -> Result<GeneratedRustQObjectBlocks> {
74+
) -> Result<GeneratedRustQObject> {
7575
let inherited_methods = vec![ParsedInheritedMethod::parse(method, safety).unwrap()];
7676
generate(&create_qobjectname(), &inherited_methods)
7777
}

crates/cxx-qt-gen/src/generator/rust/invokable.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use crate::{
77
generator::{
88
naming::{invokable::QInvokableName, qobject::QObjectName},
9-
rust::{fragment::RustFragmentPair, qobject::GeneratedRustQObjectBlocks},
9+
rust::{fragment::RustFragmentPair, qobject::GeneratedRustQObject},
1010
},
1111
parser::invokable::ParsedQInvokable,
1212
};
@@ -17,8 +17,8 @@ use syn::Result;
1717
pub fn generate_rust_invokables(
1818
invokables: &Vec<ParsedQInvokable>,
1919
qobject_idents: &QObjectName,
20-
) -> Result<GeneratedRustQObjectBlocks> {
21-
let mut generated = GeneratedRustQObjectBlocks::default();
20+
) -> Result<GeneratedRustQObject> {
21+
let mut generated = GeneratedRustQObject::default();
2222
let cpp_class_name_rust = &qobject_idents.cpp_class.rust;
2323

2424
for invokable in invokables {

crates/cxx-qt-gen/src/generator/rust/property/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub mod signal;
1010
use crate::{
1111
generator::{
1212
naming::{property::QPropertyName, qobject::QObjectName},
13-
rust::qobject::GeneratedRustQObjectBlocks,
13+
rust::qobject::GeneratedRustQObject,
1414
},
1515
parser::property::ParsedQProperty,
1616
};
@@ -23,8 +23,8 @@ pub fn generate_rust_properties(
2323
properties: &Vec<ParsedQProperty>,
2424
qobject_idents: &QObjectName,
2525
qualified_mappings: &BTreeMap<Ident, Path>,
26-
) -> Result<GeneratedRustQObjectBlocks> {
27-
let mut generated = GeneratedRustQObjectBlocks::default();
26+
) -> Result<GeneratedRustQObject> {
27+
let mut generated = GeneratedRustQObject::default();
2828
let mut signals = vec![];
2929

3030
for property in properties {

0 commit comments

Comments
 (0)