Run tests with code coverage enabled, and upload coverage to Codecov (attempt 2) #42
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage ? 89.36%
=========================================
Files ? 2
Lines ? 94
Branches ? 0
=========================================
Hits ? 84
Misses ? 10
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Alright, Codecov is finally working. Looks like we have 89% line coverage currently. We can work on getting that up to 100% in future PRs. |
DilumAluthge
force-pushed
the
dpa/code-coverage-2
branch
from
162cab6 to
154ed17
Compare
|
To see the code coverage, go to this URL: https://app.codecov.io/gh/JuliaParallel/SlurmClusterManager.jl/pull/42/tree You will probably need to log into Codecov using your GitHub account. |
DilumAluthge
force-pushed
the
dpa/code-coverage-2
branch
from
483768b to
3189117
Compare
|
@kleinhenz This is ready for review now. |
DilumAluthge
force-pushed
the
dpa/code-coverage-2
branch
from
3189117 to
410734b
Compare
|
@kleinhenz Just FYI, I have a stack of PRs to improve coverage:
After those PRs, the final code coverage is 97%, which is pretty good. |
|
Bump @kleinhenz |
kleinhenz
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #41 (closes #41).
Alright, Codecov is finally working. Looks like we have 89% line coverage currently. We can work on getting that up to 100% in future PRs.
To see the code coverage, go to this URL: https://app.codecov.io/gh/JuliaParallel/SlurmClusterManager.jl/pull/42/tree
You will probably need to log into Codecov using your GitHub account.