Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download progress fixes. Show compressed registry add confirmation. #3979

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Download progress fixes. Show compressed registry add confirmation. #3979

merged 3 commits into from
Aug 5, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

@IanButterworth IanButterworth commented Aug 5, 2024 •
edited
Loading

  1. There was no confirmation after the compressed registry was downloaded

Fixes #3747

  1. Downloads.jl shortcuts creating an async task if progress == nothing https://github.com/JuliaLang/Downloads.jl/blob/29954592f49052159af2cce536f0f4e11efe540b/src/Downloads.jl#L400
  1. Skip showing the progress bar during the initial header download to prevent it looking glitchy

Fixes #3977

@IanButterworth IanButterworth marked this pull request as draft August 5, 2024 03:41
@IanButterworth IanButterworth changed the base branch from ib/fix_download_repeats to master August 5, 2024 03:59
@IanButterworth IanButterworth marked this pull request as ready for review August 5, 2024 11:12
@IanButterworth IanButterworth reopened this Aug 5, 2024
@IanButterworth IanButterworth merged commit 7aef1f0 into master Aug 5, 2024
7 checks passed
@IanButterworth IanButterworth deleted the ib/down_progbar_tweaks branch August 5, 2024 19:50
IanButterworth added a commit that referenced this pull request Aug 5, 2024
@IanButterworth
Download progress fixes. Show compressed registry add confirmation. (#…
a7ee271 
…3979)

* set progressbar to nothing for efficiency

Downloads.jl shortcuts if progress == nothing

* don't show glitchy progress during header download

* add missing compressed registry add confirmation

(cherry picked from commit 7aef1f0)
@IanButterworth IanButterworth mentioned this pull request Aug 5, 2024
Merged
3 tasks
IanButterworth added a commit that referenced this pull request Aug 5, 2024
@IanButterworth
Download progress fixes. Show compressed registry add confirmation. (#…
8ee5275 
…3979)

* set progressbar to nothing for efficiency

Downloads.jl shortcuts if progress == nothing

* don't show glitchy progress during header download

* add missing compressed registry add confirmation

(cherry picked from commit 7aef1f0)
@IanButterworth IanButterworth mentioned this pull request Aug 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@IanButterworth