Download progress fixes. Show compressed registry add confirmation. (#…

…3979)

* set progressbar to nothing for efficiency

Downloads.jl shortcuts if progress == nothing

* don't show glitchy progress during header download

* add missing compressed registry add confirmation

src/PlatformEngines.jl

@@ -275,11 +275,15 @@ function download(
             (total, now) -> begin
                 bar.max = total
                 bar.current = now
-                show_progress(io, bar)
+                # Downloads.download attatches the progress indicator to the header request too
+                # which is only ~100 bytes, and will report as 0 - 100% progress immediately
+                # then dip down to 0 before the actual download starts. So we only show the
+                # progress bar once the real download starts.
+                total > 1000 && show_progress(io, bar)
             end
         end
     else
-        (total, now) -> nothing
+        nothing
     end
     try
         Downloads.download(url, dest; headers, progress)

src/Registry/Registry.jl

@@ -206,6 +206,7 @@ function download_registries(io::IO, regs::Vector{RegistrySpec}, depot::String=d
             open(joinpath(regdir, reg.name * ".toml"), "w") do io
                 TOML.print(io, reg_info)
             end
+            printpkgstyle(io, :Added, "`$(reg.name)` registry to $(Base.contractuser(regdir))")
         else
             mktempdir() do tmp
                 if reg.path !== nothing && reg.linked == true # symlink to local source