CompatHelper: bump compat for Adapt to 4, (keep existing compat) #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This passes all tests on my machine while using Adapt v4.0.0 julia> versioninfo()
Julia Version 1.11.0-DEV.1156
Commit ae9185b88c (2023-12-24 20:25 UTC)
Platform Info:
OS: Linux (x86_64-linux-gnu)
CPU: 2 × Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
WORD_SIZE: 64
LLVM: libLLVM-15.0.7 (ORCJIT, broadwell)
Threads: 1 on 2 virtual cores``` |
|
Is it possible to get the PR merged, this is needed for Flux: FluxML/Flux.jl#2362 |
|
+1 |
|
Bump. Would be nice to have this merged and released soon so that packages that depend on this can also update compat. |
…30-658-01903112359
|
Thanks! |
Contributor
|
For folks who help maintain this package, I can also invite you to be contributors on the org. Please let me know who I should add. |
ViralBShah
deleted the
compathelper/new_version/2023-12-19-00-51-30-658-01903112359
branch
|
I'll take care of releasing v0.6.17 if you add me but I don't know how much I can contribute otherwise. |
|
Oh wait it seems like #291 (comment) is saying the next release might be 0.7. In that case I'd just backport the compat change in a new branch based off v0.6.16 and not risk breaking any current compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Adaptpackage from3.4to3.4, 4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.