Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 19, 2023

This pull request changes the compat entry for the Adapt package from 3.4.0 to 3.4.0, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Edit: closes #775

@oxinabox
Copy link
Member

why did CI not run?

@oxinabox oxinabox closed this Dec 19, 2023
@oxinabox oxinabox reopened this Dec 19, 2023
@oxinabox
Copy link
Member

ok here we go

@oxinabox
Copy link
Member

According to CI this actually failed to be resolvable.
I think we need to concurrently relax bounds on Adapt, StaticArrays, and GPUArrays.

@mcabbott
Copy link
Member

Needs JuliaArrays/StructArrays.jl#292

@christiangnrd
Copy link
Contributor

StructArrays v0.6.17 with compat for Adapt v4 has been released

@roflmaostc
Copy link

What exactly holds this back?

@mcabbott
Copy link
Member

Many tests failed when last I ran them. Perhaps this PR just needs to be rebased on master, if those are fixed in the meantime?

@christiangnrd
Copy link
Contributor

The tests are unrelated to this patch. I've run the test suite on main and on main with Adapt 4 and the exact same tests fail. This could probably be merged and hopefully released soon as it's blocking a few downstream PRs.

@mcabbott
Copy link
Member

The same tests as fail on CI, or different ones?

On CI it's all about one / zero, for which there were various recent PRs. But I don't have bandwith to dig into this.

Am a bit reluctant to release things with tests failing, regardless of assurances that it's no worse than before.

@christiangnrd
Copy link
Contributor

Understandable. I reran tests for both versions on Macos and Linux (4 runs total) and they're all erroring the same as the CI for Julia 1.10 on x64.

The one / zero errors were fixed by #773. A rebase of this PR should show the same 1 failure and 8 errors as #773

While those were running, I also fixed new CI failures in a separate PR (#776) that should be a quick review.

@oxinabox oxinabox force-pushed the compathelper/new_version/2023-12-19-00-49-41-437-00320506041 branch from 1f2531a to f2fbf81 Compare January 29, 2024 06:22
@oxinabox
Copy link
Member

Passing on 1.6 x64. x86 timed out

And the remaining failures on 1.10 are preexisting. (and have fixes)

@oxinabox oxinabox merged commit dd95290 into main Jan 29, 2024
@oxinabox oxinabox deleted the compathelper/new_version/2023-12-19-00-49-41-437-00320506041 branch January 29, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bump Adapt to 4 in Project.toml

5 participants