Skip to content

fix: load base64 image on android #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: load base64 image on android #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09cc1fe
fix: load base64 image on android
alexisrougnant Dec 13, 2024
19837bf
fix: handle base64 string before coil img
alexisrougnant Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion android/src/main/java/com/jimmydaddy/imagemarker/MarkerImageLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.graphics.Bitmap
import android.graphics.BitmapFactory
import android.os.Build
import android.os.Build.VERSION.SDK_INT
import android.util.Base64
import android.util.Log
import androidx.annotation.RequiresApi
import androidx.core.graphics.drawable.toBitmap
Expand Down Expand Up @@ -48,9 +49,22 @@ class MarkerImageLoader(private val context: ReactApplicationContext, private va
val deferredList = images.map { img ->
async {
try {

val isCoilImg = isCoilImg(img.uri)
Log.d(IMAGE_MARKER_TAG, "isCoilImg: $isCoilImg")
if (isCoilImg) {

if (isBase64String(img.uri)) {
Log.d(IMAGE_MARKER_TAG, "Loading Base64 Image")
decodeBase64ToBitmap(img.uri)?.let { bitmap ->
val scaledBitmap = ImageProcess.scaleBitmap(bitmap, img.scale)
?: throw MarkerError(ErrorCode.LOAD_IMAGE_FAILED, "Failed to scale Base64 image")
if (!bitmap.isRecycled && img.scale != 1f) {
bitmap.recycle()
System.gc()
}
return@async scaledBitmap
} ?: throw MarkerError(ErrorCode.GET_RESOURCE_FAILED, "Failed to decode Base64 image")
} else if (isCoilImg) {
val future = CompletableFuture<Bitmap?>()
var request = ImageRequest.Builder(context)
.data(img.uri)
Expand Down Expand Up @@ -130,4 +144,20 @@ class MarkerImageLoader(private val context: ReactApplicationContext, private va
)
}


private fun isBase64String(s: String?): Boolean {
if (s == null) return false
return s.startsWith("data:image/") && s.contains(";base64,")
}

private fun decodeBase64ToBitmap(base64Str: String?): Bitmap? {
if (base64Str == null) return null
return try {
val imageBytes = Base64.decode(base64Str.substring(base64Str.indexOf(",") + 1), Base64.DEFAULT)
BitmapFactory.decodeByteArray(imageBytes, 0, imageBytes.size)
} catch (e: Exception) {
Log.e("ImageLoader", "Failed to decode Base64 image", e)
null
}
}
}