Skip to content

fix: load base64 image on android #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexisrougnant
Copy link

fix #230 #231

Issue

Passing a base64 image as source does not work on Android

Marker.markImage({
  backgroundImage: {
    src: require('./images/test.jpg'),
    scale: 1,
  },
  watermarkImages: [{
    src: waterMarkImageBase64String,
    position: {
      position: Position.topLeft,
    },
  }],
})

The following error throws on native side:

isCoilImg: true
start to load image: data:image/png;base64,...
Failed to load image: data:image/png;base64,...

Actually coil does not seem to support base64 image: coil-kt/coil#2580

Fix

  • make MarkerImageLoader loadImages handle base64 strings (and before coil images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Crashing on Mark Image (android)
1 participant