Skip to content

fix(miner): validate commit SHA format in replay-snapshot path planner (#7796) #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RealDiligent wants to merge 1 commit into from
Closed

fix(miner): validate commit SHA format in replay-snapshot path planner (#7796) #7841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/loopover-miner/lib/replay-snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ function normalizeDbPath(dbPath: string): string {

const FIELD_SEP = "\x1f";
const README_NAME_PATTERN = /^readme(\.\w+)?$/i;
const COMMIT_SHA_PATTERN = /^[0-9a-f]{7,40}$/i;

function normalizeRepoFullName(repoFullName: string): string {
if (typeof repoFullName !== "string") throw new Error("invalid_repo_full_name");
Expand All @@ -77,7 +78,9 @@ function normalizeRepoFullName(repoFullName: string): string {

function normalizeCommitSha(commitSha: string): string {
if (typeof commitSha !== "string" || !commitSha.trim()) throw new Error("invalid_commit_sha");
return commitSha.trim();
const trimmed = commitSha.trim();
if (!COMMIT_SHA_PATTERN.test(trimmed)) throw new Error("invalid_commit_sha");
return trimmed.toLowerCase();
}

/** Worktree exports live under this dir inside the repo, mirroring worktree-allocator.ts's WORKTREE_SUBDIR. */
Expand Down
Loading
Loading