fix(miner): validate commit SHA format in replay-snapshot path planner (#7796) - #7841
Closed
RealDiligent wants to merge 1 commit into
Closed
Conversation
RealDiligent
force-pushed
the
fix/replay-snapshot-sha-validation-7796-v2
branch
from
July 21, 2026 14:51
ea9695b to
e8a18cc
Compare
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7841 +/- ##
==========================================
- Coverage 91.37% 88.41% -2.96%
==========================================
Files 729 89 -640
Lines 74688 21318 -53370
Branches 22793 3698 -19095
==========================================
- Hits 68246 18849 -49397
+ Misses 5396 2291 -3105
+ Partials 1046 178 -868
Flags with carried forward coverage won't be shown. Click here to find out more.
|
RealDiligent
force-pushed
the
fix/replay-snapshot-sha-validation-7796-v2
branch
from
July 21, 2026 14:57
e8a18cc to
bddf4db
Compare
JSONbored#7796) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/^[0-9a-f]{7,40}$/ivalidation tonormalizeCommitSha(matchingreplay-task-generation.ts) so path-traversal-shaped values are rejected beforepath.join()n- Normalize valid SHAs to lowercase for deterministic snapshot pathsCloses #7796
Made with Cursor