Skip to content

docs(ui): federated fleet intelligence operator-consent page#6631

Merged
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
RealDiligent:feat/critical-issue-federated-fleet-docs-6482-v2
Jul 16, 2026
Merged

docs(ui): federated fleet intelligence operator-consent page#6631
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
RealDiligent:feat/critical-issue-federated-fleet-docs-6482-v2

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

Closes #6482

Test plan

Made with Cursor

RealDiligent and others added 2 commits July 17, 2026 00:29
Closes JSONbored#6482

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 16, 2026 16:36
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 16, 2026
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-16 16:45:26 UTC

6 files · 1 AI reviewer · no blockers · readiness 86/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR adds a docs-only page (federated-fleet-intelligence.mdx) plus the standard thin TanStack Router wiring (route file, generated routeTree, nav/palette/index links) matching the existing pattern used by every other docs page in this repo. The content accurately reflects the shipped code in src/orb/federated-collector.ts (opt-in gating via resolveCollectorEndpoint, no default collector, SSRF-safe URL check, shape-only bundle validation with no trust/signature verification yet) and is honest about #6480 not having landed. The routeTree.gen.ts diff is machine-generated (as with every other route addition in this file) and the `as any` cast at line 337 is a pre-existing pattern repeated for the new route, not a new risk.

Nits — 6 non-blocking
  • The routeTree.gen.ts `as any` casts (e.g. apps/loopover-ui/src/routeTree.gen.ts:337) are pre-existing codegen boilerplate, but worth confirming this file is truly auto-generated and not hand-edited, since hand-editing it would be a real risk.
  • No test coverage is added for the new route file (apps/loopover-ui/src/routes/docs.federated-fleet-intelligence.tsx), though this matches the apparent convention of the other docs.*.tsx route files, which also appear untested.
  • The MDX claims collectorUrl must pass 'the same SSRF-safe URL rules as other manifest URL fields' — worth double-checking that federatedIntelligence.collectorUrl is actually validated at manifest-parse time (not just at collector-call time via isSafeHttpUrl in federated-collector.ts) so the doc's config-time claim matches reality.
  • The docs promise `collectorMode: both` as the default when collectorUrl is set — confirm this matches resolveCollectorEndpoint's `config.collectorMode ?? "both"` fallback (it does, per the provided source), so no drift there, but keep an eye on this doc/code contract if the default ever changes.
  • Consider adding a one-line note in the MDX pointing directly to the FederatedSignalBundleBody type definition file for readers who want the authoritative schema rather than a hand-copied table.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6598, #6482
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ❌ 8/20 High review scope from cached public metadata (2 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 357 registered-repo PR(s), 174 merged, 32 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 357 PR(s), 32 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: moderate
Linked issue satisfaction

Addressed
The PR adds the federated-fleet-intelligence.mdx content covering exported fields, opt-in/out via .loopover.yml, and trust-gating design as the issue asked, and wires it into the docs route, nav, Maintainers index, and command palette so it's discoverable, matching the issue's stated scope.

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 357 PR(s), 32 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add a concise scope and risk note.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/docs/federated-fleet-intelligence desktop before /docs/federated-fleet-intelligence
before /docs/federated-fleet-intelligence
after /docs/federated-fleet-intelligence
after /docs/federated-fleet-intelligence
/docs/federated-fleet-intelligence mobile before /docs/federated-fleet-intelligence (mobile)
before /docs/federated-fleet-intelligence (mobile)
after /docs/federated-fleet-intelligence (mobile)
after /docs/federated-fleet-intelligence (mobile)
/docs desktop before /docs
before /docs
after /docs
after /docs
/docs mobile before /docs (mobile)
before /docs (mobile)
after /docs (mobile)
after /docs (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit a47d1c3 into JSONbored:main Jul 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operator-consent + privacy docs for federated fleet intelligence opt-in

1 participant