feat(mcp): register loopover_close_pr write-tool to match its 8 siblings (#6615)#6713
Closed
shin-core wants to merge 1 commit into
Closed
feat(mcp): register loopover_close_pr write-tool to match its 8 siblings (#6615)#6713shin-core wants to merge 1 commit into
shin-core wants to merge 1 commit into
Conversation
…ngs (JSONbored#6615) buildClosePrSpec was the only one of the 9 local-write-tool builders with no MCP tool. Register loopover_close_pr in both surfaces (src/mcp/server.ts remote + packages/loopover-mcp/bin/loopover-mcp.js stdio CLI) following the exact pattern of loopover_apply_labels: input shape, category entry, import, and a handler that returns localWriteSpec(buildClosePrSpec(input)). No new write path or auth — pure parity. Tests cover both the plain and with-comment commands in the server + CLI write-tool suites. Closes JSONbored#6615
superagent-security
Bot
added
the
contributor:flagged
Contributor
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 17 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 9 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
loopover-orb
Bot
added
the
gittensor:bug
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-16 20:28:17 UTC
Review summary Nits — 3 non-blocking
CI checks failing
Flagged checks (non-blocking)
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (4), validate-tests (6), validate-tests (5), validate-tests (1), validate-tests (2), validate-tests (3), validate-code)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildClosePrSpecwas the only one of the 9local-write-tools.tsbuilders with no MCP tool, despite being fully implemented, tested, and used internally byclaim-conflict-resolver.js.loopover_close_prin both surfaces, mirroring the 8 siblings exactly:src/mcp/server.ts:closePrShape,MCP_TOOL_CATEGORIESentry ("agent"),buildClosePrSpecimport, and aregister(...)handler returninglocalWriteSpec(buildClosePrSpec(input)).packages/loopover-mcp/bin/loopover-mcp.js: import,closePrShape,STDIO_TOOL_DESCRIPTORSentry, and aregisterStdioTool(...)block.buildClosePrSpecverbatim (gh pr close <n> --repo '<repo>', optionally&& gh pr comment ...).Closes #6615
Test plan
test/unit/mcp-write-tools.test.ts(server) +test/unit/mcp-cli-write-tools.test.ts(CLI) pass, covering both the plain and with-commentloopover_close_prcommands.npm run typecheckclean.Notes
test/unit/mcp-tool-rename-aliases.test.tsfrom 62 → 63 (with the standard count-history comment), since adding a tool increments the live registry count that test pins.