Skip to content

feat(mcp): add issue-slop CLI for issue-quality self-checks#2656

Closed
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli
Closed

feat(mcp): add issue-slop CLI for issue-quality self-checks#2656
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

The gittensory_check_issue_slop MCP tool and POST /v1/lint/issue-slop API already triage low-effort issues from title/body alone, but contributors had no shell equivalent for pre-submit checks without an MCP session.

This change adds gittensory-mcp issue-slop, a thin CLI wrapper that posts to /v1/lint/issue-slop with --title, --body, and --body-file. Plain output prints the slop score, band, and findings; --json returns the full report. Completes the lint CLI trio alongside lint-pr-text (merged) and slop-risk (#2655).

No linked issue — fills the same CLI gap pattern as the other lint self-check tools.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Full gate run via npm run test:ci (includes all checks above).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — MCP CLI only; no visible UI changes.

Notes

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995
jimcody1995 requested a review from JSONbored as a code owner July 3, 2026 00:53
@dosubot dosubot Bot added the size:XS label Jul 3, 2026
@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-03 05:45:06 UTC

4 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The diff adds a focused `gittensory-mcp issue-slop` CLI path, wires it into command dispatch/help/typo suggestions, and covers plain output, JSON output, file input, help, and elevated findings through the fixture server. The implementation mirrors the existing lint CLI shape and the changed test harness exercises the real CLI-to-API call path, so the visible change is safe enough to proceed. The only notable rough edge is flag validation around `--body-file` when the value is omitted or non-string, which affects error quality rather than correctness.

Nits — 5 non-blocking
  • nit: `packages/gittensory-mcp/bin/gittensory-mcp.js:1491` should validate `options.bodyFile` with the same string-option normalization used for `--title` and `--body`, so `--body-file` without a value fails with a clear CLI error instead of falling through to `existsSync` with a boolean.
  • nit: `test/unit/mcp-cli-issue-slop.test.ts:72` covers a missing file path but not the omitted-value case for `--body-file`; adding that case would lock in the intended parser behavior.
  • In `packages/gittensory-mcp/bin/gittensory-mcp.js:1491`, normalize `options.bodyFile` before `existsSync`, for example by reusing `normalizeOptionalStringOption(options.bodyFile)` and checking the resulting path.
  • In `test/unit/mcp-cli-issue-slop.test.ts:72`, add a small assertion for `runAsync(["issue-slop", "--body-file"], e)` once the intended error message is explicit.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 12 registered-repo PR(s), 4 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 12 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 12 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (6ff28c4) to head (d7ef18a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2656   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         237      237           
  Lines       26472    26472           
  Branches     9602     9602           
=======================================
  Hits        25438    25438           
  Misses        425      425           
  Partials      609      609           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts due to your previous PR being merged...

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/JSONbored/gittensory/pull/2656/conflicts) or the command line to resolve conflicts before continuing.

packages/gittensory-mcp/README.md
packages/gittensory-mcp/bin/gittensory-mcp.js
test/unit/support/mcp-cli-harness.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants