Skip to content

feat(mcp): add issue-slop CLI for issue-quality self-checks#2701

Closed
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli
Closed

feat(mcp): add issue-slop CLI for issue-quality self-checks#2701
jimcody1995 wants to merge 1 commit into
JSONbored:mainfrom
jimcody1995:feat/mcp-issue-slop-cli

Conversation

@jimcody1995

@jimcody1995 jimcody1995 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add gittensory-mcp issue-slop as a stdio CLI mirror of gittensory_check_issue_slop and POST /v1/lint/issue-slop
  • Support --title, --body, --body-file, and --json for agent self-checks before opening issues
  • Handle empty --body "" via normalizeOptionalStringOption so falsy empty strings are not dropped by parseOptions

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • None skipped; full npm run test:ci passed locally.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — MCP CLI only; no visible UI changes.

Notes

Expose POST /v1/lint/issue-slop as a stdio CLI mirror of gittensory_check_issue_slop so agents can self-check issue quality before opening work.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995
jimcody1995 requested a review from JSONbored as a code owner July 3, 2026 06:47
@loopover-orb

loopover-orb Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-03 07:27:51 UTC

4 files · 1 AI reviewer · 1 blocker · readiness 80/100 · CI green · dirty

🛑 Suggested Action - Reject/Close

  • AI reviewers agree on a likely critical defect: packages/gittensory-mcp/bin/gittensory-mcp.js:1564 returns the full `/v1/lint/issue-slop` payload for `--json`, which exposes fields the existing `gittensory_check_issue_slop` public contract intentionally omits
  • return only `band` and `findings` or justify why the CLI is allowed to be less blunt than the MCP tool. — Resolve the flagged defect, or override if the AI reviewers are mistaken, then re-run the gate.

Review summary
The CLI wiring, option parsing, body-file handling, help text, fixture route, and README example are coherent, and the empty `--body ""` path is intentionally preserved through `normalizeOptionalStringOption`. The main defect is that the new public CLI exposes the raw issue-slop numeric score and rubric even though the existing MCP issue-slop contract deliberately blunts those fields, so the new mirror does not match the safer public surface.

Blockers

  • packages/gittensory-mcp/bin/gittensory-mcp.js:1564 returns the full `/v1/lint/issue-slop` payload for `--json`, which exposes fields the existing `gittensory_check_issue_slop` public contract intentionally omits; return only `band` and `findings` or justify why the CLI is allowed to be less blunt than the MCP tool.
  • packages/gittensory-mcp/bin/gittensory-mcp.js:1566 prints the raw numeric issue-slop score in plain output, making the non-JSON path leak the same private scoring detail; change the line to report only the band, for example `process.stdout.write(`Issue slop risk: ${payload.band}\n`);`.
Nits — 5 non-blocking
  • test/unit/mcp-cli-issue-slop.test.ts:33 currently asserts the leaked JSON fields are present, so update the test to match the blunted CLI contract and explicitly assert those raw fields are absent.
  • test/unit/mcp-cli-issue-slop.test.ts:63 currently asserts the exact numeric score in the fixture response path, so cover the elevated band and finding title without coupling the CLI contract to the raw scoring value.
  • packages/gittensory-mcp/bin/gittensory-mcp.js:1563 introduce a small `bluntIssueSlopPayload(payload)` helper beside the CLI and use it for both JSON and plain output so future fixture/API additions do not automatically become public CLI output.
  • test/unit/mcp-cli-issue-slop.test.ts:33 mirror `test/unit/mcp-check-slop-risk.test.ts` by asserting the JSON output lacks the raw scoring and rubric fields.
  • test/unit/support/mcp-cli-harness.ts:479 can keep returning the richer API fixture, but the CLI test should prove the command sanitizes that richer payload before printing it.

Why this is blocked

  • packages/gittensory-mcp/bin/gittensory-mcp.js:1564 returns the full `/v1/lint/issue-slop` payload for `--json`, which exposes fields the existing `gittensory_check_issue_slop` public contract intentionally omits; return only `band` and `findings` or justify why the CLI is allowed to be less blunt than the MCP tool.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ Linked #2656
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 15 registered-repo PR(s), 5 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 15 PR(s), 0 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: TypeScript, JavaScript
  • Official Gittensor activity: 15 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 3, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts + review blockers:

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/JSONbored/gittensory/pull/2701/conflicts) or the command line to resolve conflicts before continuing.

test/unit/support/mcp-cli-harness.ts

@JSONbored JSONbored closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants