Skip to content

feat(mcp): add windsurf host to init-client config#2608

Closed
glorydavid03023 wants to merge 2 commits into
JSONbored:mainfrom
glorydavid03023:feat/mcp-init-client-windsurf
Closed

feat(mcp): add windsurf host to init-client config#2608
glorydavid03023 wants to merge 2 commits into
JSONbored:mainfrom
glorydavid03023:feat/mcp-init-client-windsurf

Conversation

@glorydavid03023

Copy link
Copy Markdown
Contributor

Summary

Adds windsurf to gittensory-mcp init-client --print, so Windsurf users can generate their MCP config the same way as the other supported hosts.

Windsurf reads ~/.codeium/windsurf/mcp_config.json using the same shared mcpServers JSON shape as claude / cursor / mcp, so it reuses that snippet branch (no new snippet is needed, unlike vscode's servers / "type": "stdio" shape).

$ gittensory-mcp init-client --print windsurf
{
  "mcpServers": { "gittensory": { "command": "gittensory-mcp", "args": ["--stdio"] } }
}

This mirrors the earlier vscode host addition (#1770): the usage text, the empty-client and unsupported-client error messages, and the README example + host description are all updated, and a test asserts the windsurf snippet equals the shared mcpServers snippet.

No issue because issue creation is restricted on this repo for outside accounts; this is a small additive host with no schema or API change.

Scope

  • Conventional Commit title; focused; follows CONTRIBUTING; small self-evident change (no linked issue).

Validation

  • git diff --check
  • npm run typecheck
  • npm run build:mcp (node --check on the CLI is clean)
  • npm run test:mcp-pack (see note)
  • npm run test:coverage (scoped: test/unit/mcp-cli-basics.test.ts — 20 pass, including the added windsurf snippet assertion; the CLI is exercised by spawning init-client --print windsurf)
  • npm run ui:openapi:check / ui:* — N/A (no UI change; mirrors feat(mcp): add VS Code host to init-client config #1770 which touched no UI)
  • npm audit --audit-level=moderate
  • New/changed behavior has tests

If any required check was skipped, explain why:

  • Change confined to the MCP package CLI + README + one test (plain JS, outside Codecov's src/**/*.ts include, so no patch-coverage obligation). build:mcp passes and init-client --print windsurf prints the shared mcpServers snippet; mcp-cli-basics.test.ts passes (20). I could not run test:mcp-pack locally because this machine runs Node 24 while the repo pins Node 22 (.nvmrc); scripts/check-mcp-package.mjs throws ERR_INVALID_ARG_TYPE on Node 24 identically on unmodified main. CI runs the full matrix on the pinned Node.

Safety

  • No secrets/wallets/hotkeys/trust/reward/private terms exposed.
  • Public GitHub text stays sanitized and low-noise.
  • Auth/cookie/CORS/session negative-path tests. — N/A.
  • API/OpenAPI/MCP behavior updated/tested where needed. (Additive CLI host; covered by the added test. No request/response schema changed.)
  • UI changes use live API data. — N/A: no UI change.
  • UI Evidence. — N/A: no visible UI change.
  • Docs/changelog updated where needed. (README updated; changelogs are release-prep artifacts.)

Notes

Add `windsurf` to `gittensory-mcp init-client --print`. Windsurf reads
~/.codeium/windsurf/mcp_config.json using the same shared `mcpServers` JSON
shape as claude/cursor/mcp, so it reuses that snippet branch rather than needing
its own (unlike vscode's `servers`/`type` shape).

Updates the usage text, the empty-client and unsupported-client error messages,
and the README example + host description. A test asserts the windsurf snippet
equals the shared mcpServers snippet.

No issue because issue creation is restricted on this repo; this is a small
additive host, mirroring the vscode host addition (JSONbored#1770), no schema/API change.
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - reject/close recommended

Review updated: 2026-07-02 23:23:48 UTC

3 files · 1 AI reviewer · 1 blocker · readiness 78/100 · CI green · blocked

🛑 Suggested Action - Reject/Close

  • AI reviewers agree on a likely critical defect: apps/gittensory-ui/src/routes/docs.mcp-clients.tsx:29 still omits `gittensory-mcp init-client --print windsurf` from the generated-config command list
  • add that command alongside codex/claude/cursor/mcp so the public docs match the new CLI surface. — Resolve the flagged defect, or override if the AI reviewers are mistaken, then re-run the gate.

Review summary
This adds `windsurf` to the MCP CLI help, error messaging, snippet dispatch, README, and the CLI basics test, and the core `init-client --print windsurf` path correctly reuses the shared `mcpServers` JSON branch. The CLI behavior in the visible diff is coherent and covered by a real spawn-based test. The remaining issue is documentation parity: the public MCP clients docs still omit the new host from the generated-config command list, so users following the site do not see the newly supported client.

Blockers

  • apps/gittensory-ui/src/routes/docs.mcp-clients.tsx:29 still omits `gittensory-mcp init-client --print windsurf` from the generated-config command list; add that command alongside codex/claude/cursor/mcp so the public docs match the new CLI surface.
Nits — 3 non-blocking
  • packages/gittensory-mcp/bin/gittensory-mcp.js:2757 adds a useful Windsurf path comment, but the host list is now duplicated across help text, validation errors, docs, and tests; consider centralizing the supported-client labels to reduce the next host-addition drift.
  • Update apps/gittensory-ui/src/routes/docs.mcp-clients.tsx:29 to include the Windsurf command and adjust the nearby explanatory paragraph if you want the site to name Windsurf explicitly rather than only relying on the generic `mcp` wording.
  • Consider adding a focused assertion for the unsupported-client error text in test/unit/mcp-cli-basics.test.ts so future host additions cannot update dispatch without updating user-facing guidance.

Why this is blocked

  • apps/gittensory-ui/src/routes/docs.mcp-clients.tsx:29 still omits `gittensory-mcp init-client --print windsurf` from the generated-config command list; add that command alongside codex/claude/cursor/mcp so the public docs match the new CLI surface.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 229 registered-repo PR(s), 146 merged, 10 issue(s).
Contributor context ✅ Confirmed Gittensor contributor glorydavid03023; Gittensor profile; 229 PR(s), 10 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Review context
  • Author: glorydavid03023
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 229 PR(s), 10 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (05cff17) to head (53997af).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
+ Coverage   96.07%   96.09%   +0.02%     
==========================================
  Files         235      237       +2     
  Lines       26357    26444      +87     
  Branches     9559     9587      +28     
==========================================
+ Hits        25322    25412      +90     
  Misses        425      425              
+ Partials      610      607       -3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing gittensory review, closing.

@JSONbored JSONbored closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants