Skip to content

feat(mcp): add lint-pr-text CLI for pre-push PR text checks#2623

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
jimcody1995:feat/mcp-lint-pr-text-cli
Jul 2, 2026
Merged

feat(mcp): add lint-pr-text CLI for pre-push PR text checks#2623
JSONbored merged 2 commits into
JSONbored:mainfrom
jimcody1995:feat/mcp-lint-pr-text-cli

Conversation

@jimcody1995

@jimcody1995 jimcody1995 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

The gittensory_lint_pr_text MCP tool and POST /v1/lint/pr-text API already lint commit messages and PR bodies against the Gittensory traceability and Conventional Commit rubric, but contributors had no shell equivalent for CI hooks or pre-push checks without spinning up an MCP session.

This change adds gittensory-mcp lint-pr-text, a thin CLI wrapper that posts to /v1/lint/pr-text with --commit (repeatable), --body, --body-file, and --linked-issue, mirroring the MCP tool input shape. Plain output prints the verdict, score, summary, and fixes; --json returns the full report.

No linked issue — discovered by comparing existing MCP tools (gittensory_lint_pr_text, gittensory_check_slop_risk) against the CLI surface (preflight, analyze-branch) where lint had no shell mirror.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Full gate run via npm run test:ci (includes all checks above).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — MCP CLI only; no visible UI changes.

Notes

  • Avoids overlap with open PRs on init-client/windsurf (feat(mcp): add windsurf host to init-client config #2608), miner packages, review-enrichment, selfhost, and gate migrations.
  • Example usage: gittensory-mcp lint-pr-text --commit "feat(mcp): add doctor grouping" --body-file .github/pull_request_template.md --linked-issue 160 --json

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995
jimcody1995 requested a review from JSONbored as a code owner July 2, 2026 16:47
@dosubot dosubot Bot added the size:XS label Jul 2, 2026
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 23:35:52 UTC

4 files · 1 AI reviewer · no blockers · readiness 73/100 · CI pending · blocked

⏸️ Suggested Action - Manual Review

Review summary
The diff adds a focused `gittensory-mcp lint-pr-text` CLI wrapper that posts the same commit/body/linked-issue shape as the existing API and MCP tool, plus fixture-backed tests for plain output, JSON output, body-file handling, repeatable commits, validation, help, and typo suggestions. The command wiring, repeatable option registration, positive integer parsing, and README example are coherent with the visible CLI conventions, and I do not see a reachable break in the changed code.

Nits — 6 non-blocking
  • nit: `packages/gittensory-mcp/bin/gittensory-mcp.js:1458` silently lets `--body-file` override `--body`; consider rejecting the combination or documenting the precedence so hook users do not accidentally lint different text than they passed inline.
  • nit: `packages/gittensory-mcp/bin/gittensory-mcp.js:1467` assumes the API response always has `summary`; a small defensive fallback would keep plain output readable if a future server response is malformed.
  • nit: `test/unit/mcp-cli-lint-pr-text.test.ts:17` keeps the fixture server timeout low at 1000ms, which is fine for the current fixture but may make this test more brittle on slow CI than the rest of the CLI harness if they use a shared default.
  • In `packages/gittensory-mcp/bin/gittensory-mcp.js:1458`, either throw when both `options.body` and `options.bodyFile` are present or add that precedence to `printLintPrTextHelp()`.
  • In `test/unit/mcp-cli-lint-pr-text.test.ts:57`, add an assertion in the fixture path that the repeated `--commit` values actually reach `/v1/lint/pr-text` as two messages, not just that the fixture returns a strong verdict.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 8 registered-repo PR(s), 2 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 8 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 8 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (e835ab0) to head (77c40f0).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2623   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         237      237           
  Lines       26444    26448    +4     
  Branches     9587     9589    +2     
=======================================
+ Hits        25412    25416    +4     
  Misses        425      425           
  Partials      607      607           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm label Jul 2, 2026
@JSONbored
JSONbored merged commit 0350560 into JSONbored:main Jul 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants