Skip to content

Update JEDI CI action with build cache - #1247

Merged
eap merged 2 commits into
developfrom
feature/ci-cache-migrate
Jun 24, 2026
Merged

Update JEDI CI action with build cache#1247
eap merged 2 commits into
developfrom
feature/ci-cache-migrate

Conversation

@eap

@eap eap commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Update to jedi-ci v2 with caching

run-ci-on-draft = true

Issue: JCSDA-internal/jedi-ci#77

@eap
eap requested review from shlyaeva and travissluka June 10, 2026 21:09
@eap
eap marked this pull request as ready for review June 10, 2026 21:09
@shlyaeva

Copy link
Copy Markdown
Collaborator

Is the expectation here that only one set of tests would run, and it would contain 3196 tests?

@eap
eap requested review from ashley314 and jessemarks92 June 24, 2026 15:04
@eap

eap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@shlyaeva - yes this new behavior is expected.

We still run unit tests first, then integration tests, but they are reported togeather in the same github "Check Run" object. If unit tests fail, the test finishes early and the GitHub Check Run reports failure for the unit tests.

I made this change for two reasons:

  • it matches cdash behavior: CI uses the same cdash test identity for both test runs resulting in them being combined in the cdash view. With 2 check-runs in the older version of CI, it was confusing for users reviewing "unit" results of passing tests since you would find combined unit/integration results (which could include failing integration tests even if the unit test reported success, and in all cases would show more tests than expected).
  • cached builds are much faster: Part of the reason that I reported two result objects in the old CI was that the 2-stage build was exceptionally slow and I wanted to report something before the whole 2-hour test run finished. Now that all the building is done rapidly, and before any tests run, unit tests are generally quite fast (ufo notwithstanding) so the time delta between unit tests and integration tests is significantly smaller.

@shlyaeva

Copy link
Copy Markdown
Collaborator

@eap OK, sounds good! One way to speed things up even more would be to run only this repos tests + everything downstream (no need to run anything upstream; for model interface repos this should save quite a bit of time). But this is already altogether much faster, thank you for doing this!

@shlyaeva

Copy link
Copy Markdown
Collaborator

@eap one more question: do we run CI with oasim?

@eap

eap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@shlyaeva - yes; here's the configure. Actually, I just added you to the oasim PR since I'm short on reviews.

ecbuild -Wno-dev -DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache -DBUILD_GSIBEC=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCDASH_OVERRIDE_SYSTEM_NAME=intel-Container -DCDASH_OVERRIDE_SITE=AWSBatch -DCDASH_OVERRIDE_GIT_BRANCH=0 -DCTEST_UPDATE_VERSION_ONLY=FALSE -DBUILD_IODA_CONVERTERS=ON -DBUILD_PYIRI=ON -DBUILD_ROPP=ON -DBUILD_RTTOV=ON -DBUILD_OASIM=ON -DCMAKE_DISABLE_FIND_PACKAGE_bufr_query=ON /workdir/bundle

@eap
eap merged commit fb169e0 into develop Jun 24, 2026
2 checks passed
@eap
eap deleted the feature/ci-cache-migrate branch June 24, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants