HFC: generalize cross era ticking #1295
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
force-pushed
the
amesgen/hfc-general-cross-era-ticking
branch
2 times, most recently
from
47ed819 to
aba5ef9
Compare
This makes a few things more convenient in a follow-up commit, and should be very easy for downstream users to adapt to.
A subsequent commit will remove the `InPairs` of `Translate`ions from `CanHardFork`. Apart from their use in the HFC, they are also used for Cardano to create initial non-Byron extended ledger states at Genesis. This commit refactors this logic to no longer rely on `CanHardFork`, while being semantically equivalent. See the added Note [Creating the initial extended ledger state for Cardano] for details.
Co-authored-by: Nicolas Frisby <[email protected]>
amesgen
force-pushed
the
amesgen/hfc-general-cross-era-ticking
branch
from
aba5ef9 to
a2e7828
Compare
amesgen
commented
Feb 10, 2025
Comment on lines
+127
to
+133
| -- TODO justify | ||
| case State.match (State.tip st) st' of | ||
| -- TODO Previously, this might have been 'TransitionKnown' if the | ||
| -- next era uses 'TriggerHardForkAtEpoch'. It /seems/ | ||
| -- inconsequential that we know a bit less here. | ||
| Left _ -> TransitionUnknown (ledgerTipSlot lst) | ||
| Right _ -> State.mostRecentTransitionInfo cfg st |
There was a problem hiding this comment.
FTR this is the tricky party. There will be a difference in behavior here e.g. when someone configures TriggerHardForkAtEpoch with a non-zero argument. (Ideally we want to remove that functionality, see #416.)
An alternative we discussed was to let the cross-era ticking function return a TransitionInfo, but this also seems very ad-hoc.
The other alternative is to use WhetherTickedOrNot as in #358.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Essentially a revived version of #358. Main difference/simplification is that this PR doesn't use
WhetherTickedOrNot, but this requires careful thought.