Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: draft Ticking.md #1385

Merged
merged 1 commit into from
Feb 11, 2025
Merged

docs: draft Ticking.md #1385

merged 1 commit into from
Feb 11, 2025
+98 −0

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Feb 7, 2025

Adds a document that discusses ticking and how its used within the Consensus Layer.

@nfrisby nfrisby added the documentation Improvements or additions to documentation label Feb 7, 2025
@nfrisby nfrisby requested a review from lehins February 7, 2025 19:29
@nfrisby
Copy link
Contributor Author

nfrisby commented Feb 7, 2025

Rendered: https://github.com/IntersectMBO/ouroboros-consensus/blob/nfrisby/doc-ticking/docs/website/contents/for-developers/Ticking.md

@nfrisby nfrisby force-pushed the nfrisby/doc-ticking branch 9 times, most recently from 3e2953d to d7868c1 Compare February 7, 2025 19:44
geo2a
geo2a approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@geo2a geo2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nfrisby for this write-up, it's a wealth of information! I've left a couple of minor suggestions and a question, but I think the document is ready to be merged as-is.

docs/website/contents/for-developers/Ticking.md Outdated Show resolved Hide resolved
docs/website/contents/for-developers/Ticking.md Outdated Show resolved Hide resolved
docs/website/contents/for-developers/Ticking.md Show resolved Hide resolved
docs/website/contents/for-developers/Ticking.md Outdated Show resolved Hide resolved
@nfrisby nfrisby force-pushed the nfrisby/doc-ticking branch from d7868c1 to 388cc18 Compare February 11, 2025 15:27
@nfrisby nfrisby force-pushed the nfrisby/doc-ticking branch from 388cc18 to a41fcb6 Compare February 11, 2025 15:33
@nfrisby nfrisby enabled auto-merge February 11, 2025 15:33
@nfrisby nfrisby added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 8029d4a Feb 11, 2025
14 checks passed
@nfrisby nfrisby deleted the nfrisby/doc-ticking branch February 11, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasagredo jasagredo jasagredo left review comments

@geo2a geo2a geo2a approved these changes

@amesgen amesgen Awaiting requested review from amesgen amesgen is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

@lehins lehins Awaiting requested review from lehins

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation no changelog
Projects
Consensus Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nfrisby @geo2a @jasagredo @amesgen