Fix an off by 1 error in GREET0. #1969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a one line change on line 2624 (new file). I have *no idea* how the FILEINFO READTABLE was changed from "XCL" to "INTERLISP". That's what's causing all of the other diffs.
MattHeffron
added
bug
|
NO. Don't change the read table. |
nbriggs
dismissed
pamoroso’s stale review
This should not be approved with the readtable change.
|
@pamoroso - Build full instead of apps |
|
I'm guessing that there was a MAKEFILE ... 'NEW there? If you let it loadfrom prop the GREET0 function, add a SUB1 for the month, and then (CLEANUP HIST) it remakes the file with only the one function changed and retains the original XCL readtable, and doesn't mess with the case of all the other code in the file. |
|
Replaced by PR #1970 with clean file diffs. |
MattHeffron
added a commit
that referenced
this pull request
Jan 15, 2025
Replaces mth26 branch (PR #1969). This doesn't change the file's READTABLE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #1968
This is a one line change on line 2624 (new file). I have no idea how the FILEINFO READTABLE was changed from "XCL" to "INTERLISP". That's what's causing all of the other diffs.
(Anyone have ideas why?)