Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GREET just wished me "Happy Valentine's Day" a month early #1968

Closed
MattHeffron opened this issue Jan 14, 2025 · 1 comment · Fixed by #1970
Closed

GREET just wished me "Happy Valentine's Day" a month early #1968

MattHeffron opened this issue Jan 14, 2025 · 1 comment · Fixed by #1970
Assignees
Labels
bug Something isn't working (as per documentation)

Comments

@MattHeffron
Copy link
Contributor

MattHeffron commented Jan 14, 2025

GREET just wished me "Happy Valentine's Day" a month early!
image
GREETDATES correctly has Valentines Day as "14-FEB".
In GREET0 it is using

(CL:MULTIPLE-VALUE-BIND (SECONDS MINUTES HOUR DAY MONTH YEAR)
  (CL:GET-DECODED-TIME) 

to get the parts of the date, and then constructing the day-month string to SASSOC into GREETDATES
However, it is using

(CL:NTH MONTH '("JAN" "FEB" "MAR" ; etc

to get the month text, but CL:NTH is zero-based, so MONTH = 1 gets "FEB"

@MattHeffron MattHeffron self-assigned this Jan 14, 2025
@MattHeffron MattHeffron added the bug Something isn't working (as per documentation) label Jan 14, 2025
@MattHeffron MattHeffron linked a pull request Jan 14, 2025 that will close this issue
@rmkaplan
Copy link
Contributor

rmkaplan commented Jan 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (as per documentation)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants