-
Notifications
You must be signed in to change notification settings - Fork 101
feat: support App variant #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmedAlaaInstabug
wants to merge
4
commits into
dev
Choose a base branch
from
feat/suppot-app-variant
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
project.ext.instabug = [ | ||
version: '14.3.0.6760192-SNAPSHOT' | ||
version: '15.0.1' | ||
] | ||
|
||
dependencies { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,7 +148,9 @@ public void init( | |
final ReadableArray invocationEventValues, | ||
final String logLevel, | ||
final boolean useNativeNetworkInterception, | ||
@Nullable final String codePushVersion | ||
@Nullable final String codePushVersion, | ||
@Nullable final String appVariant | ||
|
||
) { | ||
MainThreadHandler.runOnMainThread(new Runnable() { | ||
@Override | ||
|
@@ -173,6 +175,9 @@ public void run() { | |
builder.setCodePushVersion(codePushVersion); | ||
} | ||
} | ||
if (appVariant != null) { | ||
builder.setAppVariant(appVariant); | ||
} | ||
builder.build(); | ||
} | ||
}); | ||
|
@@ -500,6 +505,8 @@ public void run() { | |
}); | ||
} | ||
|
||
|
||
|
||
/** | ||
* Removes user attribute if exists. | ||
* | ||
|
@@ -1037,7 +1044,7 @@ public void run() { | |
} | ||
|
||
/** | ||
* @deprecated see {@link #addFeatureFlags(ReadableArray)} | ||
* @deprecated see {@link #addFeatureFlags(ReadableMap)} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should be reverted to |
||
*/ | ||
@ReactMethod | ||
public void addExperiments(final ReadableArray experiments) { | ||
|
@@ -1351,4 +1358,19 @@ public void run() { | |
} | ||
}); | ||
} | ||
|
||
/** | ||
* Sets current App variant | ||
* | ||
* @param appVariant The app variant name . | ||
*/ | ||
@ReactMethod | ||
public void setAppVariant(@NonNull String appVariant) { | ||
try { | ||
Instabug.setAppVariant(appVariant); | ||
|
||
} catch (Exception e) { | ||
e.printStackTrace(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ target 'InstabugExample' do | |
rn_maps_path = '../node_modules/react-native-maps' | ||
pod 'react-native-google-maps', :path => rn_maps_path | ||
# add this line | ||
pod 'Instabug', :podspec => 'https://ios-releases.instabug.com/custom/feature-expose_network_limit-expose_body_limit/15.0.1/Instabug.podspec' | ||
# pod 'Instabug', :podspec => 'https://ios-releases.instabug.com/custom/feature-expose_network_limit-expose_body_limit/15.0.1/Instabug.podspec' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove the unnecessary comments. |
||
# Flags change depending on the env values. | ||
flags = get_default_flags() | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should set the app variant name, not trigger invocation events.