feat: support App variant #1409
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedAlaaInstabug
requested review from
AyaMahmoud148,
AndrewAminInstabug,
kholood-ea and
MoKamall
and removed request for
AyaMahmoud148
MoKamall
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
@ahmedAlaaInstabug Excellent work! Please take a moment to review the minor comments provided.
| @@ -221,6 +237,16 @@ public Builder setInvocationEvents(InstabugInvocationEvent... invocationEvents) | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the invocation triggering events for the SDK's user interface | |||
There was a problem hiding this comment.
I believe this should set the app variant name, not trigger invocation events.
| @@ -1037,7 +1044,7 @@ public void run() { | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated see {@link #addFeatureFlags(ReadableArray)} | |||
| * @deprecated see {@link #addFeatureFlags(ReadableMap)} | |||
There was a problem hiding this comment.
this should be reverted to ReadableArray
| @@ -16,7 +16,7 @@ target 'InstabugExample' do | |||
| rn_maps_path = '../node_modules/react-native-maps' | |||
| pod 'react-native-google-maps', :path => rn_maps_path | |||
| # add this line | |||
| pod 'Instabug', :podspec => 'https://ios-releases.instabug.com/custom/feature-expose_network_limit-expose_body_limit/15.0.1/Instabug.podspec' | |||
| # pod 'Instabug', :podspec => 'https://ios-releases.instabug.com/custom/feature-expose_network_limit-expose_body_limit/15.0.1/Instabug.podspec' | |||
There was a problem hiding this comment.
Let's remove the unnecessary comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support App variant
Type of change
Related issues
JIRA ID: GER-7368
Checklists
Development
Code review