Skip to content

fix(e2e): assert real prod metrics shape in live-reads (Batch A) #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mastermanas805 merged 1 commit into from
Jun 5, 2026
Merged

fix(e2e): assert real prod metrics shape in live-reads (Batch A) #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions e2e/live-reads.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,18 @@ test.describe('LIVE — Batch A read flows (W-OBS / W-RES / W-VAULT / W-APIKEYS
if (metrics.status() === STATUS_OK) {
const m = await bodyJSON(metrics)
expect(m.ok, 'metrics ok flag').toBe(true)
// Real prod shape: { ok, data_source, metrics: { <metricName>: number[] , ... } }
// (metrics is an OBJECT keyed by series name, not a top-level array).
expect(
Array.isArray(m.metrics),
`metrics must carry a metrics[] series; got ${JSON.stringify(m).slice(0, 200)}.`,
m.metrics != null && typeof m.metrics === 'object' && !Array.isArray(m.metrics),
`metrics must be an object keyed by metric name; got ${JSON.stringify(m).slice(0, 200)}.`,
).toBe(true)
expect(m.window_seconds, 'metrics must echo the resolved window_seconds').toBeTruthy()
const series = Object.values(m.metrics ?? {})
expect(
series.length > 0 && Array.isArray(series[0]),
`metrics must carry at least one named time-series array; got ${JSON.stringify(m).slice(0, 200)}.`,
).toBe(true)
expect(m.data_source, 'metrics must declare a data_source').toBeTruthy()
}

// ── Explicit DELETE assertion (W-RES formalizes the authed reap) ─────────
Expand Down
Loading