fix(e2e): assert real prod metrics shape in live-reads (Batch A) - #183
Merged
Conversation
… array)
Batch A read run failed: /api/v1/resources/:id/metrics returns
{ok, data_source, metrics:{<name>:number[]}} (object keyed by metric name),
but the spec asserted Array.isArray(metrics). Assert the real shape: metrics
is a non-array object with >=1 named time-series array + a data_source.
Supersedes the conflicted #182.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mastermanas805
enabled auto-merge (squash)
June 5, 2026 07:46
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
live-reads.spec.ts asserted metrics as an array; real prod shape is an object keyed by metric name ({ok,data_source,metrics:{:number[]}}). Fix the assertion to the real contract. Supersedes conflicted #182.