Test PR

.github/workflows/lint.yml

@@ -2,9 +2,9 @@ name: Code formatting and linting
 
 on:
   push:
-    branches: [ master ]
+    branches: [ master, ci-rework ]
   pull_request:
-    branches: [ master ]
+    branches: [ master, ci-rework ]
 
 env:
   BUILD_TYPE: Debug
@@ -32,10 +32,12 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
+          version: '19'
           database: 'build'
           ignore: 'QML|data|.github|build|Engine/3rdparty|Engine/shaders|tools'
           style: 'file'
           tidy-checks: ''
+          step-summary: true
           files-changed-only: false
           tidy-review: true
           format-review: true

Engine/Engine.cpp

@@ -178,7 +178,8 @@ void Engine::showQMLComponent(const QString &url)
 
     for (auto root : d->qmlEngine->rootObjects())
     {
-        QMetaObject::invokeMethod(root, "changeScreen", Q_ARG(QVariant, QUrl(url)), Q_ARG(QVariant, QVariantMap()));
+        QMetaObject::invokeMethod(root, "destroyAndChangeScreen", Q_ARG(QVariant, QUrl(url)),
+                                  Q_ARG(QVariant, QVariantMap()));
     }
 }
 

ImagePlugin/QtOpenSRImagePlugin.cpp

@@ -110,7 +110,9 @@ QImageIOHandler *QtOpenSRImagePlugin::create(QIODevice *device, const QByteArray
 
 QStringList QtOpenSRImagePlugin::keys() const
 {
-    return QStringList() << "gi" << "gai" << "hai" << "psd";
+    QStringList keys;
+    keys << "gi" << "gai" << "hai" << "psd";
+    return keys;
 }
 } // namespace OpenSR
 

Ranger/GILoader.cpp

@@ -100,15 +100,15 @@ void drawR5G6B5(QImage &result, int x, int y, QIODevice *dev)
                 quint16 color{};
                 dev->read((char *)&color, 2);
                 *((uint32_t *)row) = (0xff000000) | (((color >> 11) & 0x1f) << 19) | (((color >> 5) & 0x3f) << 10) |
-                                     (((color) & 0x1f) << 3);
+                                     ((color & 0x1f) << 3);
                 row += 4;
                 cnt--;
 
                 while (cnt > 0)
                 {
                     dev->read((char *)&color, 2);
                     *((uint32_t *)row) = (0xff000000) | (((color >> 11) & 0x1f) << 19) | (((color >> 5) & 0x3f) << 10) |
-                                         (((color) & 0x1f) << 3);
+                                         ((color & 0x1f) << 3);
                     row += 4;
                     cnt--;
                 }

World/Planet.h

@@ -44,7 +44,7 @@ class OPENSR_WORLD_API PlanetStyle : public Resource
     struct Data
     {
         QString surface, cloud0, cloud1, background;
-        int radius;
+        int radius{};
         QColor atmosphere;
     };
 

World/Ship.h

@@ -39,7 +39,7 @@ class OPENSR_WORLD_API ShipStyle : public Resource
     struct Data
     {
         QString texture;
-        int width;
+        int width{};
     };
 
     int width() const;