Skip to content

Test PR#2

Open
InfernalKn1ght wants to merge 5 commits into
ci-reworkfrom
ci-lint-test
Open

Test PR#2
InfernalKn1ght wants to merge 5 commits into
ci-reworkfrom
ci-lint-test

Conversation

@InfernalKn1ght
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch
diff --git a/World/Ship.h b/World/Ship.h
index db7fa75..a00c933 100644
--- a/World/Ship.h
+++ b/World/Ship.h
@@ -42 +42 @@ public:
-        int width;
+        int width{};
diff --git a/World/Planet.h b/World/Planet.h
index 39fa029..f0eb4d2 100644
--- a/World/Planet.h
+++ b/World/Planet.h
@@ -47 +47 @@ public:
-        int radius;
+        int radius{};

Used clang-format v19.1.1

No concerns from clang-format.

Have any feedback or feature suggestions? Share it here.

@github-actions github-actions Bot dismissed their stale review June 12, 2025 14:40

outdated suggestion

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Used clang-format v19.1.1

Click here for the full clang-format patch
diff --git a/Engine/Engine.cpp b/Engine/Engine.cpp
index b00f896..4287801 100644
--- a/Engine/Engine.cpp
+++ b/Engine/Engine.cpp
@@ -181 +181,2 @@ void Engine::showQMLComponent(const QString &url)
-        QMetaObject::invokeMethod(root, "destroyAndChangeScreen", Q_ARG(QVariant, QUrl(url)), Q_ARG(QVariant, QVariantMap()));
+        QMetaObject::invokeMethod(root, "destroyAndChangeScreen", Q_ARG(QVariant, QUrl(url)),
+                                  Q_ARG(QVariant, QVariantMap()));

Have any feedback or feature suggestions? Share it here.

Comment thread Engine/Engine.cpp Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot dismissed their stale review June 12, 2025 18:44

outdated suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant