Determine eltype
and ndims
type parameter positions automatically
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the functionality removed in #26 but with a more robust strategy.
This uses the fact that when an AbstractArray subtype with unconventional type parameter positions for
eltype
andndims
is defined, the information of where those type parameters are defined can be determined by matching the names of the TypeVars of the type parameters to the same name in the AbstractArray type output byInteractiveUtils.supertypes
, for example:So you can see that we can determine that the 4th parameter of
MyBoolArray
must be thendims
type parameter, since it has a nameB
matching thendims
parameter of its AbstractArray supertype.In principle this can work with non-AbstractArray types (using the internal function
TypeParameterAccessors.position_from_supertype
) but for now that is opt-in and an internal feature.