More default_type_parameters
definitions
#35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines missing overloads of
default_type_parameters
for array types in package extensions.In addition, it defines a fallback definition using a similar logic to #31. As an example, the package doesn't explicitly define a
default_type_parameters
overload forLinearAlgebra.Diagonal
but with this PR we get:Note that it only defines default parameters that are defined for a supertype (in this case,
AbstractArray
defines defaults foreltype
andndims
). Undefined parameters are output asTypeParameterAccessors.UndefinedDefaultTypeParameter()
, which when accessed by position throws an error.I'm open to suggestions about other ways to design that. It seems reasonable, at least with the current design, since types may not want to define defaults for every type parameter, though probably we could rethink that design with #27.
Todo: