Skip to content

Say when the code-health ratchet was not evaluated - #99

Merged
IAnMove merged 1 commit into
mainfrom
chore/code-health-ratchet-status
Sep 2, 2026
Merged

Say when the code-health ratchet was not evaluated#99
IAnMove merged 1 commit into
mainfrom
chore/code-health-ratchet-status

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Follow-up to #97. --markdown without --check now prints Ratchet not evaluated. Tests cover that preview, --check pass, and a ratchet failure.

Also refreshes docs/development/SLICE_QUEUE.md after #94/#95/#97/#98. comunicaciones/ remains local handoff, not a canonical source.

Does not touch useStore.ts, _launch_runtime.py or StoryLabPanel.tsx.


Note

Low Risk
Documentation and reporting-only changes to code_health.py with no production runtime or security impact.

Overview
Markdown code-health output now states Ratchet not evaluated. when you run --markdown without --check, so local previews are not mistaken for CI pass/fail. With --check --markdown, reports still end in Ratchet passed. or Ratchet failed. as before.

Tests in test_code_health.py cover all three markdown outcomes (preview, pass, failure). CODE_HEALTH.md and SLICE_QUEUE.md document the flag behavior and refresh the slice queue through landed work #94#98.

Reviewed by Cursor Bugbot for commit 3bc1e10. Configure here.

`--markdown` without `--check` now prints **Ratchet not evaluated.** instead
of omitting the status. Tests cover preview, passed and failed tables.

Update SLICE_QUEUE.md to the post-#95/#97/#98 state. comunicaciones/ stays
session handoff, not canonical.
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 4 file(s); +51/-16; docs, repo scripts / CI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • No heuristic issues. Still run the CI checklist below.

Changed files

  • modified: docs/development/CODE_HEALTH.md, docs/development/SLICE_QUEUE.md, scripts/code_health.py, tests/test_code_health.py

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@IAnMove

IAnMove commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

cursor review

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Code health

Metric Value
Production LOC 234,016
Production files 493
Test LOC 64,036
Functions measured 14,625
Functions complexity ≥ 15 777
Maximum complexity 667

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
667 app/wgp.py:7157 generate_video
374 ui/src/stores/useStore.ts:4532 Async method 'startGeneration'
356 app/_launch_runtime.py:23733 _run_generation
308 app/wgp.py:12274 generate_video_tab
272 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:469 Function 'SceneAnimatorPanel'
266 ui/src/stores/useStore.ts:9658 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
254 app/services/director_pipeline.py:13539 _run_video_generation
245 app/services/director_pipeline.py:7663 _run_pipeline
241 ui/src/features/agent/agentActions.ts:1077 Function 'parseAction'
227 ui/src/features/agent/agentActions.ts:2672 Async function 'executeAgentActions'
226 app/services/director_pipeline.py:6492 update_comic_preview

Trend vs baseline

Metric Δ
Production LOC +351
Test LOC +222
Functions ≥ 15 +3
Maximum complexity +0

Warnings

  • production LOC increased by +351
  • functions at complexity >= 15 increased by +3
  • complexity hotspot ui/src/stores/useStore.ts rose 373 -> 374
  • complexity hotspot app/services/model3d_service.py rose 51 -> 54
  • hotspot app/_launch_runtime.py increased by +66 lines
  • hotspot ui/src/stores/useStore.ts increased by +11 lines
  • hotspot ui/src/features/agent/agentActions.ts increased by +3 lines
  • hotspot ui/src/types/index.ts increased by +3 lines
  • hotspot app/services/model3d_service.py increased by +58 lines
  • hotspot ui/src/features/agent/capabilityRegistry.ts increased by +2 lines
  • hotspot ui/src/features/agent/applicationAdapters.ts increased by +5 lines

Ratchet passed.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 3bc1e10. Configure here.

@IAnMove
IAnMove merged commit c11b6f8 into main Sep 2, 2026
5 checks passed
@IAnMove
IAnMove deleted the chore/code-health-ratchet-status branch September 5, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant