Extract Story Lab assets tab with i18n - #100
Merged
Merged
Conversation
Move the smart importer, style conversion and visual library out of StoryLabPanel. Handlers stay in the panel; the tab only renders. New files stay at complexity ≤ 25. Does not touch useStore.ts or _launch_runtime.py.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Owner
Author
|
cursor review |
Code health
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c6504c5. Configure here.
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Overview left
StoryLabPanelin #98. The Assets tab (smart importer, style conversion, visual library) was the remaining inline chrome with English literals.What
StoryAssetsTabcomposes importer, proposal cards, style converter and librarystoryLab.assetscatalogDoes not touch
useStore.tsor_launch_runtime.py. Independent of #99 (ratchet wording).Checks
tsc -p tsconfig.app.json --noEmittest_story_lab_audio_ui,test_story_lab_trailer_ui,test_provider_ternary_freezeNote
Low Risk
Refactor and localization only; asset import, style conversion, and draft deletion logic remain in
StoryLabPanelwith no store or backend changes described.Overview
Pulls the Story Lab Assets tab out of
StoryLabPanelintoStoryAssetsTaband smaller pieces (importer, proposal cards, style converter, visual library), with state and handlers still wired from the panel. User-visible copy moves intostoryLab.assets(EN/ES) viauseUiTranslation, andStoryLabPanelno longer embeds hundreds of lines of English literals for that tab.Adds
storyLabAssets.tsforPendingSmartAssetandstoryAssetKey(used by proposal cards). i18n pilot coverage, Python UI contract tests, and Story Lab extract tests now target the catalog and new modules so moved strings stay enforced.Reviewed by Cursor Bugbot for commit c6504c5. Configure here.