Extract Story Lab assembly tab and library chrome i18n - #102
Closed
IAnMove wants to merge 1 commit into
Closed
Conversation
Move assembly and leftover library chrome out of StoryLabPanel. Handlers stay in the panel; tab labels, project types and chrome copy live in storyLab EN/ES catalogs. New files stay at complexity ≤ 25. Does not touch useStore.ts or _launch_runtime.py.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code health
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
Owner
Author
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 37cee0f. Configure here.
Owner
Author
|
Superseded by #103 (this extract plus remaining visible i18n, restacked on current main). Branch kept. |
Owner
Author
|
Closed as superseded by #103. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Assets left
StoryLabPanelin #100. The Assembly tab and leftover library chrome (header, tab labels, project types, Guided/Automatic, prepare buttons, Cancel/Resume/Storypack/Import/Smart assets/New/Duplicate, nav notes) still mixed EN/ES inline.What
StoryAssemblyTabis presentational;StoryProductionTimelinestays here withinitiallyOpen={index === 0}StoryLabLibraryChromeowns the header toolbar; public panel handlers (generate,exportStorypack,importStorypack,newProject, reopen/restore) stay inStoryLabPanelstoryLabTabs.tsis data-driven (id: 'trailer',id: 'assembly'); labels come from i18nstoryLabcatalogs for library chrome, project types, tabs, nav notes and assembly copystoryLabTabs/StoryAssemblyTabDoes not touch
useStore.tsor_launch_runtime.py. Independent of any in-flightuseStoreslice PR.Checks
tsc -p tsconfig.app.json --noEmitstoryLabResponsive,i18nFoundation)test_story_lab_trailer_ui,test_series_lab_ui,test_story_lab_audio_uiHumans merge; checks must be green.
Note
Low Risk
UI refactor and copy migration only; no changes to
useStore.ts, backend, or generation behavior beyond wiring the same handlers into new components.Overview
Pulls Assembly and the library header toolbar out of
StoryLabPanelintoStoryAssemblyTabandStoryLabLibraryChrome, with tab/project-type definitions centralized instoryLabTabs.ts. Generation, import/export, and reopen/restore handlers stay in the panel; the new pieces are mostly presentational and call back through props.i18n (EN+ES): Adds
storyLabkeys for library chrome (save status, prepare buttons, Storypack/Import/Smart assets, etc.), project types, tab labels, nav notes, and assembly copy.StoryLabNavigation’s mobile swipe hint usesnav.swipe. The i18n pilot list and forbidden-literal checks cover the extracted files so mixed inline strings are blocked.Tests/docs: Python UI contracts and Story Lab responsive/i18n tests now assert catalogs and
storyLabTabs/StoryAssemblyTabinstead of hardcoded strings in the panel.SLICE_QUEUE.mdreflects Assets (#100) and describes this slice as the next Story Lab extract.Reviewed by Cursor Bugbot for commit 37cee0f. Configure here.