i18n: chrome visible restante (Story Lab, Series Lab, bienvenida, cola) - #103
Merged
Conversation
Move assembly and leftover library chrome out of StoryLabPanel. Handlers stay in the panel; tab labels, project types and chrome copy live in storyLab EN/ES catalogs. New files stay at complexity ≤ 25. Does not touch useStore.ts or _launch_runtime.py.
Move leftover Spanish/English UI copy into EN+ES catalogs (storyLab issues, notices and timeline; seriesLab; director queue recovery; welcome; gallery montage actions). Fix the Story Lab E2E tab name to Trailer. Retarget tests that asserted hardcoded words.
Owner
Author
|
cursor review |
PR Review — Loreframe StudioRisk: medium Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code health
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f93811c. Configure here.
CI failed because the feed button copy moved from a hardcoded
"Usar en posición" string to t('montage.useInPosition').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Por qué
La UI aún mezclaba ES/EN fuera de catálogo. Este PR parte de
main(incluye #101) y trae el extract de Assembly de #102, más el chrome visible que faltaba.Qué entra al sistema i18n
Tráiler, que rompía CI de Extract Story Lab assembly tab and library chrome i18n #102)EN es la fuente; ES va en el mismo commit. Workspace sigue siendo Workspace; carpeta física = Output folder / Carpeta de salida.
Qué no se tocó a propósito
Prompts de LLM,
agentActions/actions.ts, IDs, nombres de modelo. Siguen avisos EN de Story Lab (música, assets, etc.) y chrome de Director/Comics/Video Editor/Character Kits: siguiente pasada.Tests
npm test: 505 passedcheck-i18n-catalogs.mjsokNo mezclar hasta CI verde. #102 queda subsumido aquí (mismo extract + i18n + main).
Note
Low Risk
Refactor and catalog-driven UI copy with broad test updates; no auth, API, or generation pipeline behavior changes beyond localized labels.
Overview
Moves remaining Story Lab shell UI into
StoryAssemblyTab,StoryLabLibraryChrome, andstoryLabTabs.ts, and routes tab labels, project types, library/prepare actions, assembly copy, approval issues, trailer notices, and production timeline strings throughstoryLabEN+ES catalogs instead of inline ES/EN literals.Adds
director(queue recovery dialog) andseriesLab(lab tabs, review assembly chrome, shot duration) namespaces,common.welcomefor the first-run modal, andactivity.montagefor assembly replacement banners and feed actions. Registers namespaces inresources.tsand extendscheck-i18n-catalogs.mjspilot coverage so migrated phrases cannot reappear as hardcoded strings.Playwright Story Lab e2e now clicks Trailer (English tab label). Python source contracts and UI tests assert
t('…')usage and default English button text where the app falls back to EN.Reviewed by Cursor Bugbot for commit f93811c. Configure here.