Skip to content

Fix review persist dropping Approve after notes blur - #405

Merged
IAnMove merged 4 commits into
developmentfrom
cursor/critical-bug-management-7363
Sep 12, 2026
Merged

IAnMove merged 4 commits into
developmentfrom
cursor/critical-bug-management-7363

Conversation

@cursor

@cursor cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

Al escribir notas y pulsar directamente «Aprobar», el blur iniciaba un guardado y se perdía la aprobación. La solución inicial todavía perdía acciones intermedias y el aviso de guardado desplazaba el botón antes de terminar el clic del ratón.

El escritorio mantiene una cola FIFO de decisiones sobre la misma producción y reserva espacio para el aviso de guardado. Aprobar, rechazar o cambiar de toma se pueden encadenar; exportar, regenerar, navegar y editar notas esperan a que termine el guardado. Solo se exporta el estado confirmado, y la respuesta del servidor actualiza la proyección con las tomas recuperadas. La comparación A/B elegida por el usuario se conserva al guardar y al refrescar el dashboard, sin restaurar aprobaciones, notas o selecciones antiguas sobre el estado del servidor. Esto corrige el hallazgo de Bugbot en b430cca9.

Validación local del ajuste final: 29 pruebas dirigidas, lint y prueba E2E con clic real en Chromium (incluye tipos y build). Las regresiones de clic desplazado y comparación perdida fallaron antes de los arreglos y pasan después. También se comprueba que conservar la comparación no resucita decisiones no confirmadas ni tomas eliminadas. La suite completa del HEAD final pasa 1726 pruebas en GitHub Actions. API simulada en E2E; no genera medios.

Base actualizada a development (60e867a6), que ya incluye #404. HEAD final e390195f9c0c1382f0f471a2ee215f26f41fad9e. Todas las GitHub Actions del HEAD final correctas, incluido CI required, E2E Chromium y speech Windows: CI del HEAD. Ratchet correcto contra la base vigente. El hilo de Bugbot sobre la comparación está resuelto y las dos automatizaciones de Cursor han terminado correctamente. El check formal opcional Independent QA permanece neutral, no certificado. Preparado para integrar; no mezclado en development.

Queue the next review mutation onto the latest desired desk so a notes-blur save in flight cannot silently drop Approve, Reject, or take selection.

Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
@IAnMove
IAnMove changed the base branch from fix/integration-audit-20260912 to development September 12, 2026 18:20
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 5 file(s); +248/-30; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • added: ui/e2e/specs/production-review.spec.ts
  • modified: ui/src/features/production-review/ProductionReviewDesk.tsx, ui/src/features/production-review/ProductionReviewHost.tsx, ui/src/features/production-review/takes.ts, ui/tests/productionReviewRuntime.test.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown

Code health

Quality score: 63.8/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 59.2 +0.0
File concentration 25% 73.7 +0.0
Oversized-file debt 20% 49.4 +0.0
Modularity 10% 88.3 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 313,695
Production files 1,052
Test LOC 127,983
Functions measured 21,377
Functions complexity ≥ 15 906
Maximum complexity 674
Policy code-health-policy-v1
HEAD abe1bc7e51a8ce9c70a8c4a113afb05d77ab08cc
Base 60e867a6aae832d5b56c5ebd44b99867bda55b26
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
674 app/wgp.py:7230 generate_video
382 ui/src/stores/useStore.ts:4129 Async method 'startGeneration'
355 app/_launch_runtime.py:23674 _run_generation
308 app/wgp.py:12372 generate_video_tab
269 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:508 Function 'SceneAnimatorPanel'
264 ui/src/stores/useStore.ts:8684 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
248 app/services/director_pipeline.py:13612 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
233 ui/src/features/agent/agentActions.ts:1152 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2998 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +45
Test LOC +173
Functions ≥ 15 +0
Maximum complexity +0

Warnings

  • production LOC increased by +45

Ratchet passed.

@IAnMove
IAnMove marked this pull request as ready for review September 12, 2026 18:44

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b430cca. Configure here.

Comment thread ui/src/features/production-review/ProductionReviewDesk.tsx
@IAnMove
IAnMove marked this pull request as draft September 12, 2026 18:58
@IAnMove
IAnMove marked this pull request as ready for review September 12, 2026 19:01
@IAnMove
IAnMove merged commit be5a731 into development Sep 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants