fix(review): preserve recovered takes and stale-video guards - #406
Merged
Conversation
save_review read the raw pipeline checkpoint, so historical takes that GET backfills from sidecars could not be selected and a successful save replaced the dashboard with a file that omitted that history. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
IAnMove
changed the base branch from
fix/integration-audit-20260912
to
development
September 12, 2026 18:19
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 63.8/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
Backfill used a Studio selection as playback authority and also cleared video_stale. After an image rerun the selected take no longer matches the new start frame, but load, prompt edits, and review persist then let Rejoin assemble that outdated video. Keep the selection for playback and leave video_stale for callers that gate export. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
IAnMove
marked this pull request as ready for review
September 12, 2026 18:34
IAnMove
marked this pull request as draft
September 12, 2026 18:42
…tale-selected' into codex/review-pr406-20260912 # Conflicts: # tests/test_director_review.py
Rejoin gated video_stale only on the non-H3 path. MiniMax H3 productions still assembled playable segments or a Studio selection after the start image changed, so the joined movie no longer matched the current frame. Raise the same stale-clip error before the H3 branch. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
25 tasks
IAnMove
changed the title
IAnMove
marked this pull request as ready for review
September 12, 2026 18:52
…3-stale-rejoin' into codex/review-pr406-20260912
IAnMove
marked this pull request as draft
September 12, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guardar notas, seleccionar una toma o aprobarla conserva ahora el historial que Director recupera de los metadatos de los vídeos. Antes, la pantalla mostraba tomas recuperadas que el guardado rechazaba o hacía desaparecer.
save_reviewcarga la misma proyección que la lectura del pipeline, dentro del bloqueo existente, y persiste las decisiones sobre ese estado. Mantiene la comprobación de workspace, el bloqueo de producción activa y la escritura atómica.Incluye íntegramente #409 y #410, detectado por la automatización de Cursor durante esta revisión: recuperar la toma seleccionada no debe borrar
video_staledespués de regenerar la imagen inicial. El control de Rejoin se aplica tanto a los vídeos normales como a MiniMax H3 y H3 Legacy, con segmentos o una toma seleccionada. Esta corrección evita que el nuevo guardado persista como actual una toma obsoleta.Cobertura adicional para conservar IDs y datos previos, rechazar una toma perteneciente a otra producción, evitar escrituras parciales al fallar un lote con historial recuperado y conservar la marca de vídeo obsoleto en lectura, notas y Rejoin. Las pruebas de #406, #409 y #410 se mantienen juntas. Los cuatro casos H3 comprueban que no se concatena ni se modifica el checkpoint cuando el vídeo está obsoleto.
Validación local: 83 pruebas de
tests/test_director_review.py,tests/test_director_cancellation.pyytests/test_director_h3_workflow_edits.pycorrectas, compilación Python, guard de repositorio ygit diff --checkcorrectos. El caso de selección obsoleta falla antes del arreglo de #409. Las pruebas usan archivos temporales, metadatos y concatenación simulados; no generan vídeo.Base actualizada a
development(60e867a6), que ya incluye #404. HEAD finalb8e3019041fd250b90fa858f203fd79330a48f26. Ratchet local correcto contra esa base. Todas las GitHub Actions del HEAD final correctas, incluidoCI required, E2E Chromium y speech Windows: CI del HEAD. Las dos automatizaciones de Cursor finalizaron correctamente. El check formal opcionalIndependent QAsigue neutral, no certificado. Preparado para integrar; no mezclado en development.