Skip to content

fix(characters): no mezclar el historial de Character Creator al cambiar de workspace #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAnMove merged 1 commit into from
Aug 31, 2026
Merged

fix(characters): no mezclar el historial de Character Creator al cambiar de workspace #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 46 additions & 31 deletions ui/src/features/characters/CharacterCreatorPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import { useStore } from '../../stores/useStore'
import { queueFaceRigHandoff } from '../../lib/characterKitHandoff'
import { safeStorageGet, safeStorageSet } from '../../lib/safeStorage'
import {
attachCharacterCreatorMesh,
attachCharacterCreatorMeshForWorkspace,
characterCreatorHistoryKey,
parseCharacterCreatorHistory,
rememberCharacterCreatorSheet,
rememberCharacterCreatorSheetForWorkspace,
type CharacterCreatorHistoryEntry,
} from './characterCreatorHistory'
import {
Expand All @@ -26,6 +26,11 @@ import {
type OrbitSubjectKind,
} from './orbitPrompt'

const historyStorage = {
getItem: (key: string) => safeStorageGet('local', key),
setItem: (key: string, value: string) => { safeStorageSet('local', key, value) },
}

const button = 'inline-flex items-center justify-center gap-1.5 rounded-md border border-border bg-bg-tertiary px-2.5 py-1.5 text-xs text-text-secondary hover:text-text-primary hover:bg-bg-hover disabled:opacity-40 disabled:cursor-not-allowed'
const primary = 'inline-flex items-center justify-center gap-1.5 rounded-md border border-violet-400/50 bg-violet-500/15 px-2.5 py-1.5 text-xs text-violet-100 hover:bg-violet-500/25 disabled:opacity-40 disabled:cursor-not-allowed'
const MAX_REFS = 9
Expand Down Expand Up @@ -97,9 +102,13 @@ export function CharacterCreatorPanel() {
const refsRef = useRef(refs)
const aPromptRef = useRef(aPrompt)
const hunyuanGlbRef = useRef(hunyuanGlb)
const activeWorkspaceRef = useRef(activeWorkspace)
const orbitWorkspaceRef = useRef(activeWorkspace)
const hunyuanWorkspaceRef = useRef(activeWorkspace)
refsRef.current = refs
aPromptRef.current = aPrompt
hunyuanGlbRef.current = hunyuanGlb
activeWorkspaceRef.current = activeWorkspace

useEffect(() => () => {
refsRef.current.forEach(ref => { if (ref.preview) URL.revokeObjectURL(ref.preview) })
Expand Down Expand Up @@ -139,6 +148,8 @@ export function CharacterCreatorPanel() {

const generateOrbit = async () => {
if (!readyRefs.length) return
const workspaceAtStart = activeWorkspace
orbitWorkspaceRef.current = workspaceAtStart
setBusy(true)
setError(null)
setViews([])
Expand All @@ -156,7 +167,7 @@ export function CharacterCreatorPanel() {
kind,
image_paths: uploaded.map(ref => ref.path).filter((path): path is string => Boolean(path)),
roles: uploaded.map(ref => ref.role),
workspace: activeWorkspace,
workspace: workspaceAtStart,
})
resolvedAPrompt = described.a_prompt.trim()
setAPrompt(resolvedAPrompt)
Expand All @@ -176,7 +187,7 @@ export function CharacterCreatorPanel() {
num_inference_steps: CHARACTER_SHEET_STEPS,
guidance_scale: 1,
seed: -1,
workspace: activeWorkspace,
workspace: workspaceAtStart,
h3_reference_mode: 'references',
h3_ref_image_size: 'max',
minimax_h3_reference_detail: 'max',
Expand All @@ -202,11 +213,11 @@ export function CharacterCreatorPanel() {
}
}

const takePhotos = useCallback(async (sourceName: string) => {
const takePhotos = useCallback(async (sourceName: string, workspace = activeWorkspace) => {
setBusy(true)
setError(null)
try {
const metadata = await api.fetchOutputMetadata(sourceName, activeWorkspace).catch(() => null)
const metadata = await api.fetchOutputMetadata(sourceName, workspace).catch(() => null)
const rawLength = metadata?.params?.video_length
const duration = typeof rawLength === 'number' && rawLength > 0
? rawLength / 24
Expand All @@ -219,38 +230,39 @@ export function CharacterCreatorPanel() {
source: sourceName,
time,
name: `${kind}_${view.id}`,
workspace: activeWorkspace,
workspace,
})
captured.push({
id: view.id,
hunyuan: view.hunyuan,
label: kind === 'object' ? view.objectLabel : view.label,
filename: shot.filename,
url: shot.url || getFileUrl(shot.filename, activeWorkspace),
url: shot.url || getFileUrl(shot.filename, workspace),
time,
})
}
setViews(captured)
setSelectedViewId(captured[0]?.id || null)
setSelectedTime(captured[0]?.time || 0)
const entry: CharacterCreatorHistoryEntry = {
id: `sheet-${sourceName}`,
name: aPromptRef.current.trim().split(/[.!\n]/)[0].slice(0, 48) || sourceName.replace(/\.[^.]+$/, ''),
kind,
videoName: sourceName,
views: captured,
hunyuanGlb: hunyuanGlbRef.current,
workspace: activeWorkspace,
workspace,
createdAt: new Date().toISOString(),
}
setHistory(current => {
const next = rememberCharacterCreatorSheet(current, entry)
safeStorageSet('local', characterCreatorHistoryKey(activeWorkspace), JSON.stringify(next))
return next
})
const next = rememberCharacterCreatorSheetForWorkspace(historyStorage, workspace, entry)
if (activeWorkspaceRef.current === workspace) {
setViews(captured)
setSelectedViewId(captured[0]?.id || null)
setSelectedTime(captured[0]?.time || 0)
setHistory(next)
}
void loadOutputs()
} catch (reason) {
setError(reason instanceof Error ? reason.message : String(reason))
if (activeWorkspaceRef.current === workspace) {
setError(reason instanceof Error ? reason.message : String(reason))
}
} finally {
setBusy(false)
}
Expand Down Expand Up @@ -356,18 +368,20 @@ export function CharacterCreatorPanel() {
poll: () => api.fetchJobStatus(jobId!),
onValue: status => {
orbitFailuresRef.current = 0
setJobMessage(status.message || status.status)
const workspace = orbitWorkspaceRef.current
const stillOnOrigin = activeWorkspaceRef.current === workspace
if (stillOnOrigin) setJobMessage(status.message || status.status)
if (status.status === 'completed') {
const name = status.output_files.find(file => /\.(mp4|webm|mov)$/i.test(file)) || status.output_files[0] || null
setVideoName(name)
if (stillOnOrigin) setVideoName(name)
setJobId(null)
void loadOutputs()
if (name) void takePhotos(name)
if (name) void takePhotos(name, workspace)
else setBusy(false)
return
}
if (status.status === 'failed' || status.status === 'cancelled') {
setError(status.error || `Orbit ${status.status}`)
if (stillOnOrigin) setError(status.error || `Orbit ${status.status}`)
setBusy(false)
setJobId(null)
}
Expand All @@ -385,6 +399,8 @@ export function CharacterCreatorPanel() {
const generateHunyuan = async () => {
const front = views.find(view => view.hunyuan === 'front')
if (!front) return
const workspaceAtStart = activeWorkspace
hunyuanWorkspaceRef.current = workspaceAtStart
setBusy(true)
setError(null)
setHunyuanGlb(null)
Expand All @@ -396,7 +412,7 @@ export function CharacterCreatorPanel() {
operation: 'generate',
preset: 'multiview',
model_id: 'hunyuan3d-2mv-turbo',
workspace: activeWorkspace,
workspace: workspaceAtStart,
images,
texture_mode: 'v2-turbo',
cpu_offload: true,
Expand All @@ -421,26 +437,25 @@ export function CharacterCreatorPanel() {
poll: () => api.fetchHunyuan3DJob(hunyuanJobId!),
onValue: status => {
hunyuanFailuresRef.current = 0
setHunyuanMessage(status.message || status.status)
const workspace = hunyuanWorkspaceRef.current
const stillOnOrigin = activeWorkspaceRef.current === workspace
if (stillOnOrigin) setHunyuanMessage(status.message || status.status)
if (status.status === 'completed') {
setHunyuanGlb(status.filename)
if (stillOnOrigin) setHunyuanGlb(status.filename)
setHunyuanJobId(null)
setBusy(false)
const sheetName = videoName
const meshName = status.filename
if (meshName && sheetName) {
setHistory(current => {
const next = attachCharacterCreatorMesh(current, sheetName, meshName)
safeStorageSet('local', characterCreatorHistoryKey(activeWorkspace), JSON.stringify(next))
return next
})
const next = attachCharacterCreatorMeshForWorkspace(historyStorage, workspace, sheetName, meshName)
if (stillOnOrigin) setHistory(next)
}
void loadOutputs()
if (status.filename) void import('@google/model-viewer')
return
}
if (status.status === 'failed' || status.status === 'cancelled') {
setError(status.error || `Hunyuan3D ${status.status}`)
if (stillOnOrigin) setError(status.error || `Hunyuan3D ${status.status}`)
setHunyuanJobId(null)
setBusy(false)
}
Expand Down
39 changes: 39 additions & 0 deletions ui/src/features/characters/characterCreatorHistory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,42 @@ export function attachCharacterCreatorMesh(
): CharacterCreatorHistoryEntry[] {
return history.map(item => item.videoName === videoName ? { ...item, hunyuanGlb } : item)
}

export type CharacterCreatorHistoryStorage = {
getItem: (key: string) => string | null
setItem: (key: string, value: string) => void
}

/** Merge a sheet into the origin workspace store, never the in-memory list of another workspace. */
export function rememberCharacterCreatorSheetForWorkspace(
storage: CharacterCreatorHistoryStorage,
workspace: string,
entry: CharacterCreatorHistoryEntry,
limit = CHARACTER_CREATOR_HISTORY_LIMIT,
): CharacterCreatorHistoryEntry[] {
const key = characterCreatorHistoryKey(workspace)
const next = rememberCharacterCreatorSheet(
parseCharacterCreatorHistory(storage.getItem(key)),
{ ...entry, workspace },
limit,
)
storage.setItem(key, JSON.stringify(next))
return next
}

/** Attach a mesh on the origin workspace store so a later workspace switch cannot wipe or retarget it. */
export function attachCharacterCreatorMeshForWorkspace(
storage: CharacterCreatorHistoryStorage,
workspace: string,
videoName: string,
hunyuanGlb: string,
): CharacterCreatorHistoryEntry[] {
const key = characterCreatorHistoryKey(workspace)
const next = attachCharacterCreatorMesh(
parseCharacterCreatorHistory(storage.getItem(key)),
videoName,
hunyuanGlb,
)
storage.setItem(key, JSON.stringify(next))
return next
}
54 changes: 54 additions & 0 deletions ui/tests/characterCreator.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ import {
} from '../src/features/characters/orbitPrompt.ts'
import {
attachCharacterCreatorMesh,
attachCharacterCreatorMeshForWorkspace,
characterCreatorHistoryKey,
parseCharacterCreatorHistory,
rememberCharacterCreatorSheet,
rememberCharacterCreatorSheetForWorkspace,
} from '../src/features/characters/characterCreatorHistory.ts'

function installDom() {
Expand Down Expand Up @@ -73,6 +76,57 @@ test('a single object image is enough to build an orbit prompt', () => {
assert.match(prompt, /turntable/)
})

test('Character Creator history writes the origin workspace store, not the in-memory list of another workspace', () => {
const store = new Map<string, string>()
const storage = {
getItem: (key: string) => store.get(key) ?? null,
setItem: (key: string, value: string) => { store.set(key, value) },
}
const luma = {
id: 'luma',
name: 'Luma',
kind: 'character' as const,
videoName: 'luma-orbit.mp4',
views: [{ id: 'front', hunyuan: 'front' as const, label: 'Front', filename: 'luma-front.png', url: '/luma-front.png', time: 0.1 }],
workspace: 'cast-a',
createdAt: '2026-08-29T00:00:00Z',
}
const brin = {
id: 'brin',
name: 'Brin',
kind: 'character' as const,
videoName: 'brin-orbit.mp4',
views: [],
workspace: 'cast-b',
createdAt: '2026-08-29T01:00:00Z',
}
rememberCharacterCreatorSheetForWorkspace(storage, 'cast-a', luma)
rememberCharacterCreatorSheetForWorkspace(storage, 'cast-b', brin)

const lateSheet = {
id: 'luma-late',
name: 'Luma late',
kind: 'character' as const,
videoName: 'luma-late.mp4',
views: [],
workspace: 'cast-a',
createdAt: '2026-08-29T02:00:00Z',
}
const nextA = rememberCharacterCreatorSheetForWorkspace(storage, 'cast-a', lateSheet)
assert.deepEqual(nextA.map(item => item.videoName), ['luma-late.mp4', 'luma-orbit.mp4'])
assert.deepEqual(
parseCharacterCreatorHistory(storage.getItem(characterCreatorHistoryKey('cast-b'))).map(item => item.videoName),
['brin-orbit.mp4'],
)

const attached = attachCharacterCreatorMeshForWorkspace(storage, 'cast-a', 'luma-orbit.mp4', 'luma.glb')
assert.equal(attached.find(item => item.videoName === 'luma-orbit.mp4')?.hunyuanGlb, 'luma.glb')
assert.equal(
parseCharacterCreatorHistory(storage.getItem(characterCreatorHistoryKey('cast-b')))[0]?.hunyuanGlb,
null,
)
})

test('Character Creator history remembers sheets and can attach a later mesh', () => {
const first = rememberCharacterCreatorSheet([], {
id: 'one',
Expand Down
Loading