fix(characters): no mezclar el historial de Character Creator al cambiar de workspace - #25
Merged
Merged
Conversation
…iar de workspace La captura de órbita y Hunyuan fusionaban el historial en memoria del workspace activo y lo escribían en localStorage. Si el usuario cambiaba de workspace a mitad de generación, se perdían sheets anteriores y se contaminaba el otro workspace. Co-authored-by: ignaciodelcano+dcl <ignaciodelcano+dcl@gmail.com>
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
IAnMove
marked this pull request as ready for review
August 31, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug e impacto
Si el usuario genera una órbita o un mesh Hunyuan en el workspace A y cambia al workspace B mientras el trabajo sigue en curso, el historial de Character Creator se corrompe:
Causa
takePhotosy el callback de Hunyuan fusionaban el array de historial en memoria (ya recargado para B) y lo guardaban enlocalStorageusando elactiveWorkspacedel render actual.useSerializedPollsiempre llama alonValuemás reciente, así que un job empezado en A termina escribiendo con el contexto de B.Fix
Validación
luma-orbiten A ybrin-orbiten B cuando la captura de A termina "después" del cambio.npm test -- tests/characterCreator.test.tsx: 9/9.