feat(video3d): bind template slots through the shared asset picker - #240
Merged
Conversation
Replace the ad-hoc Library grid with AssetInput. Keep catalog asset.id and catalogBindingIssue; local files without an id are rejected.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
…emplates-55b1729f
The shared explorer shows a kind/date title, not the filename, so composer tests and the Library binding e2e must click title=filename and Choose. Keep catalogBindingIssue text on incompatible picks.
Composer is already a dialog, so filtering dialogs that contain asset-explorer matched both shells. Use the last overlay.
After Choose, the composer shows the catalog filename in the slot card and again in AssetInput. Strict getByText matched both.
IAnMove
marked this pull request as ready for review
September 7, 2026 20:51
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3411c45a-c622-4a0d-9290-6cc71b2bf066) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Template composer used a private Library grid with click-to-confirm and its own pagination. That is not the shared dual-origin picker, and a click confirmed immediately.
Behavior
AssetInput/ common explorer (workspaceId+ remote catalog from feat(assets): page the shared explorer against the catalog API #230).asset.id.catalogBindingIssuestill blocks incompatible items.asset_idis rejected (canonical Library identity required).IDs
TPL-01..08
Base / HEAD
origin/development661d241c(#237).Tests
templateSlotPick.test.mjs+templateAssetPicker.test.tsx: 6/6. ESLint on touched TS, 0 warnings. E2E composer flow updated to From HocusPocus → Choose.Limits
Draft until CI. No GPU. Do not merge from this description if you are a bot; human asked to merge after review.
Note
Medium Risk
Changes how Video3D template slots bind to Library assets (shared picker + async commit), which could regress slot assignment or stale bindings if the race guards fail.
Overview
Replaces the template composer’s bespoke Library grid with the shared
AssetInput/ asset explorer, so slot assignment matches the dual-origin picker used elsewhere (From my computer / From HocusPocus) and confirms with Choose instead of clicking a catalog card.commitTemplateSlotChoiceintemplateSlotPick.tsloads the durable catalog id viafetchAsset, ignores stale picks when workspace/slot/generation changes, and rejects local choices withoutasset_id(newneedsCatalogIdentitycopy).catalogBindingIssueandprovided_onlycatalog lineage behavior stay the same; the dialog now wiresonClear/ optional slots through the picker.Unit, composer, and E2E tests were updated for the explorer flow; the old paginated picker tests were dropped in favor of slot-commit coverage.
Reviewed by Cursor Bugbot for commit 1b40751. Configure here.