feat(story): bind cover and cue audio through the shared picker - #245
Merged
Conversation
Cover stays a reference, not a generated song. Lyria and custom MP3 imports keep cue identity and provenance. Catalog picks reuse the server URL instead of uploading again.
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
The source contract still requires custom-audio-upload and an mp3 accept list; those now live on the shared picker helper.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4fb608c1-b50b-46b4-b60a-1cf6855739cb) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Story cover, Lyria import and custom cue MP3 used hidden
type=fileinputs. Cover could be confused with a generated song, and catalog audio was re-uploaded.Behavior
coverReferenceFilename/coverReferenceNameonly.lyria.IDs
AUD-07..09
Base / HEAD
origin/development96818265(#241). HEADb57e4b0614757caf847d0c8aa8314417d4a061ff.Tests
storyAudioPick.test.mjs+storyLabResponsive.test.tsx: 17/17. ESLint on touched files, 0 warnings.Limits
Draft until CI. No GPU. Independent of G2-G3 #240.
Note
Medium Risk
Changes how story music audio is selected and persisted (catalog vs upload), which could affect cue/cover binding if validation or stale-selection guards regress.
Overview
Story Lab cover references, Lyria imports, and custom cue MP3s no longer use hidden file inputs and
api.uploadAudio. They go through a newStoryAudioPicker(workspaceAssetInput) so users can pick existing catalog audio or upload once, without re-uploading assets already in the workspace.storyAudioPick.tscentralizes binding: cover choices only setcoverReferenceFilename/coverReferenceName(not song candidates); Lyria and custom imports buildStoryMusicCandidaterows from the chosenApiOutputURL.commitStoryAudioChoiceignores stale project/cue selections, rejects non-audio, and enforces MP3-only for custom imports.StoryLabPanelhandlers are synchronous commits instead of upload activities; hidden Lyria/custom inputs andmusicCoverRefare removed.Tests add
storyAudioPick.test.mjs, update responsive/UI contract tests for the picker flow, and point Python source checks atstoryAudioPick.tsforcustom-audio-uploadprovenance.Reviewed by Cursor Bugbot for commit 12b07db. Configure here.