Skip to content

fix(video3d): drop pending layer bind when the explorer closes - #237

Merged
IAnMove merged 1 commit into
developmentfrom
grok/agente2-clear-bind-7b0b8595
Sep 7, 2026
Merged

IAnMove merged 1 commit into
developmentfrom
grok/agente2-clear-bind-7b0b8595

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Problem

#229 merged without clearing pendingBindRef / reassignId when the layer explorer closes. Cancel/Escape could leave a capture that a later hidden file input applies to the old layer.

Behavior

Explorer onClose drops the pending capture and reassign id.

Base

origin/development b2aee310 (#233). Follow-up to agent1 review of #229.

Tests

Same directed tests as #229; one-line close handler. No Playwright locally.


Note

Low Risk
Single close-handler change that resets in-memory UI bind state; no auth, persistence, or API changes.

Overview
Fixes a state leak when users dismiss the layer asset explorer without completing a bind. Closing the explorer (Cancel/Escape) now clears pendingBindRef and reassignId in addition to hiding the dialog, so a stale capture cannot be applied if a file picker or other flow runs afterward.

This aligns explorer dismissal with successful commit paths that already null the pending bind after applyLayerSourceCommit.

Reviewed by Cursor Bugbot for commit 422bd33. Configure here.

Cancel/Escape must not leave reassignId or a capture that a later
hidden file input could apply to the old layer.
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_f6ba58e0-8394-47c4-959b-779e6a90e523)

@IAnMove
IAnMove merged commit 661d241 into development Sep 7, 2026
7 checks passed
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 1 file(s); +1/-1; React UI

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • modified: ui/src/components/Sidebar/SceneAnimatorPanel.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 54.6/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 54.3 +0.0
File concentration 25% 61.3 +0.0
Oversized-file debt 20% 36.9 +0.0
Modularity 10% 74.9 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 263,995
Production files 697
Test LOC 92,357
Functions measured 17,025
Functions complexity ≥ 15 833
Maximum complexity 672
Policy code-health-policy-v1
HEAD 7c948c4c5a48b8afe2f3c5a7e77f498fac10c265
Base b2aee3104c590a6546ef88d1518d0017619b7bbf
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
672 app/wgp.py:7219 generate_video
381 ui/src/stores/useStore.ts:4053 Async method 'startGeneration'
355 app/_launch_runtime.py:23563 _run_generation
308 app/wgp.py:12359 generate_video_tab
268 ui/src/stores/useStore.ts:8600 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
258 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:493 Function 'SceneAnimatorPanel'
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
244 ui/src/features/agent/agentActions.ts:1145 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2892 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC +0
Test LOC +0
Functions ≥ 15 +0
Maximum complexity +0

Ratchet passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant