fix(video3d): drop pending layer bind when the explorer closes - #237
Merged
Merged
Conversation
Cancel/Escape must not leave reassignId or a capture that a later hidden file input could apply to the old layer.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f6ba58e0-8394-47c4-959b-779e6a90e523) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.6/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#229 merged without clearing
pendingBindRef/reassignIdwhen the layer explorer closes. Cancel/Escape could leave a capture that a later hidden file input applies to the old layer.Behavior
Explorer
onClosedrops the pending capture and reassign id.Base
origin/developmentb2aee310(#233). Follow-up to agent1 review of #229.Tests
Same directed tests as #229; one-line close handler. No Playwright locally.
Note
Low Risk
Single close-handler change that resets in-memory UI bind state; no auth, persistence, or API changes.
Overview
Fixes a state leak when users dismiss the layer asset explorer without completing a bind. Closing the explorer (Cancel/Escape) now clears
pendingBindRefandreassignIdin addition to hiding the dialog, so a stale capture cannot be applied if a file picker or other flow runs afterward.This aligns explorer dismissal with successful commit paths that already null the pending bind after
applyLayerSourceCommit.Reviewed by Cursor Bugbot for commit 422bd33. Configure here.