feat(assets): migrate 2.5D narrative and recipe fields to AssetInput - #213
Merged
Conversation
Character, background, prop, foreground and recipe media use the shared dual-origin control. Scene3DWorkspace is left to open PR #212.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c78b27b4-01c4-4d3b-8dc6-687780dd6cc8) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.0/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Warnings
Ratchet passed. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scene3DWorkspace— that file is in open PR #212.origin/development1e6cb636(feat(assets): add dual-origin AssetInput field #211 mixed). Do not merge until asked.Test plan
sceneAnimatorPicker.test.tsx— dual-origin buttons open the shared explorerassetInput.test.tsxstill passesCoste de la tarea
Note
Medium Risk
Changes asset selection UX in the 2.5D compositor and recipe panel (including how uploads and catalog picks are wired), though persistence still uses output names and
Scene3DWorkspaceis untouched.Overview
PR 5 (asset picker) moves several 2.5D compositor surfaces off
AssetPickTrigger/ ad‑hoc explorer + file inputs onto the sharedAssetInputdual-origin control (From my computer / From HocusPocus).Narrative template setup (hero, plate, prop, foreground) now sets slot filenames via
NarrativeAssetFieldinstead of openingSceneAnimatorExplorerthrough a singleonOpenExplorercallback;SceneAnimatorPanelwires directonHero/onPlate/ … handlers (plate change still clears loop-ready). Attaching generated scene audio uses newSceneAnimatorAudioInputinstead of thescene-audioexplorer purpose.In manual recipe mode,
SceneRecipePaneldrops the image/GLB toggle, hidden multi-file imports, and inlineAssetExplorerDialogin favor of twoAssetInputrows (images/video and GLB from app catalog); local upload flows throughAssetInputrather than panel-localimportFiles.Docs (
CURRENT_WORK,ASSET_PICKER_MIGRATION) record #211 merged and this slice as in-flight PR 5, withScene3DWorkspaceexplicitly deferred to #212. AddssceneAnimatorPicker.test.tsxasserting dual-origin buttons open the shared explorer.Reviewed by Cursor Bugbot for commit 2a0517a. Configure here.