feat(assets): migrate Hunyuan views to AssetInput - #215
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_945a9ff4-41d0-4581-92c4-78a379568bd9) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.0/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetExplorerDialog, adapters, query) — those are in #214.Scene3DWorkspace— #212.Test plan
hunyuan3DGalleryPicker.test.tsx— 3 passedCoste de la tarea
Note
Low Risk
Consumer-only UI migration on Hunyuan3DPanel and docs; generation API payloads should stay equivalent, with behavior covered by updated tests.
Overview
PR 6A wires Hunyuan3D reference images (front/left/right/back) and the retexture source GLB through shared
AssetInputinstead of bespoke upload buttons, inline gallery listboxes, and directuploadImagecalls.The panel drops
ViewUpload, per-view upload busy state, and the expandable HocusPocus image picker; workspace image outputs still load viafetchOutputsand map intochooseView. Retexture keeps a refresh control but replaces the GLB thumbnail grid plus separate import with one constrainedmodel3dfield.Docs (
CURRENT_WORK,ASSET_PICKER_MIGRATION) record #213 merged and this work as in-flight 6A, without touching picker core (#214) orScene3DWorkspace.hunyuan3DGalleryPicker.test.tsxexercises the transactional modal flow (From HocusPocus / Choose) and still asserts multiview gating, generate payload, and disabled generate when the runtime is missing.Reviewed by Cursor Bugbot for commit 2850c4a. Configure here.