Skip to content

feat(assets): migrate Hunyuan views to AssetInput - #215

Merged
IAnMove merged 2 commits into
developmentfrom
feat/asset-picker-tools-hunyuan
Sep 7, 2026
Merged

feat(assets): migrate Hunyuan views to AssetInput#215
IAnMove merged 2 commits into
developmentfrom
feat/asset-picker-tools-hunyuan

Conversation

@IAnMove

@IAnMove IAnMove commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Hunyuan front/left/right/back and retexture GLB use the shared AssetInput (From my computer / From HocusPocus).
  • Removes the ad-hoc Hunyuan gallery listbox.
  • Does not edit picker core (AssetExplorerDialog, adapters, query) — those are in #214.
  • Does not edit Scene3DWorkspace#212.
  • Tools/imagen restantes siguen pending. Do not merge until asked.

Test plan

  • hunyuan3DGalleryPicker.test.tsx — 3 passed
  • eslint, local code-health ratchet
  • Cursor review: not run (quota)

Coste de la tarea

  • Tests simulados: 0 tokens externos
  • Tests reales: N/A
  • Llamadas LLM externas: 0
  • Tokens de prompt: N/A
  • Tokens de respuesta: N/A
  • Tokens totales: N/A
  • Generaciones de imágenes/audio/vídeo: 0
  • Tiempo transcurrido: N/A
  • Proveedores/modelos: N/A

Note

Low Risk
Consumer-only UI migration on Hunyuan3DPanel and docs; generation API payloads should stay equivalent, with behavior covered by updated tests.

Overview
PR 6A wires Hunyuan3D reference images (front/left/right/back) and the retexture source GLB through shared AssetInput instead of bespoke upload buttons, inline gallery listboxes, and direct uploadImage calls.

The panel drops ViewUpload, per-view upload busy state, and the expandable HocusPocus image picker; workspace image outputs still load via fetchOutputs and map into chooseView. Retexture keeps a refresh control but replaces the GLB thumbnail grid plus separate import with one constrained model3d field.

Docs (CURRENT_WORK, ASSET_PICKER_MIGRATION) record #213 merged and this work as in-flight 6A, without touching picker core (#214) or Scene3DWorkspace.

hunyuan3DGalleryPicker.test.tsx exercises the transactional modal flow (From HocusPocus / Choose) and still asserts multiview gating, generate payload, and disabled generate when the runtime is missing.

Reviewed by Cursor Bugbot for commit 2850c4a. Configure here.

Replace the ad-hoc Hunyuan gallery picker with the shared dual-origin
control. Does not edit picker core (#214) or Scene3DWorkspace (#212).
@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_945a9ff4-41d0-4581-92c4-78a379568bd9)

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR Review — Loreframe Studio

Risk: low
Scope: 4 file(s); +100/-143; React UI, docs

Automated review from scripts/analyze_pr.py. This is a heuristic pass (no LLM) so humans still own the merge decision.

Findings

  • low — UI changed — rebuild before merge
    Run cd ui && npm run build (CI already does this). Pinokio Update rebuilds for end users; keep ui/dist untracked.

Changed files

  • modified: docs/development/ASSET_PICKER_MIGRATION.md, docs/development/CURRENT_WORK.md, ui/src/components/Sidebar/Hunyuan3DPanel.tsx, ui/tests/hunyuan3DGalleryPicker.test.tsx

CONTRIBUTING checklist

  • python scripts/verify_clean_repo.py
  • python -m compileall -q app/services app/launch.py scripts
  • cd ui && npm run build if the UI changed
  • No weights, CivitAI sidecars, or generated guides
  • Stays local-first (no required accounts / telemetry)

Posted by the repo PR review workflow. Re-runs on each push to the PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Code health

Quality score: 54.0/100

Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.

Component Weight Current Change
Cyclomatic health 45% 54.2 +0.0
File concentration 25% 60.6 -0.1
Oversized-file debt 20% 36.1 +0.0
Modularity 10% 72.4 +0.0

Change vs PR base: +0.0 points.

Metric Value
Production LOC 261,240
Production files 664
Test LOC 90,207
Functions measured 16,723
Functions complexity ≥ 15 824
Maximum complexity 670
Policy code-health-policy-v1
HEAD da19d737b03e0c1cae2527067842987d07ad13a1
Base 800e02ab30af256e10d00ab207117376784a2ada
UI measurement complete

Markdown, JSON catalogs and tests are out of this table. Only app/ runtime + ui/src TS/JS count.

Most complex functions

Complexity Where
670 app/wgp.py:7164 generate_video
376 ui/src/stores/useStore.ts:4029 Async method 'startGeneration'
355 app/_launch_runtime.py:23505 _run_generation
308 app/wgp.py:12298 generate_video_tab
271 ui/src/stores/useStore.ts:8572 Async method 'loadSettingsFromOutput'
258 app/services/director/planners/short_film.py:3433 ShortFilmPlanner._plan_story_driven
257 ui/src/components/Sidebar/SceneAnimatorPanel.tsx:478 Function 'SceneAnimatorPanel'
248 app/services/director_pipeline.py:13607 _run_video_generation
245 app/services/director_pipeline.py:7712 _run_pipeline
244 ui/src/features/agent/agentActions.ts:1145 Function 'parseAction'
226 app/services/director_pipeline.py:6541 update_comic_preview
225 ui/src/features/agent/agentActions.ts:2892 Async function 'executeAgentActions'

Trend vs baseline

Metric Δ
Production LOC -59
Test LOC +15
Functions ≥ 15 +0
Maximum complexity +0

Ratchet passed.

@IAnMove
IAnMove merged commit 86596d0 into development Sep 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant